Remove inaccurate assert in attemptQuadOptimization
This assert was only accurate if the input edge flags were all 0s or
all 1s, and set in conjunction with the overall aa policy (e.g. aa = yes
meant all edge flags were 1). Then any cropping of a large draw would
have no change when it updated the edge flags.
However, this premise is flawed when the quad has mixed edge flags,
since it could still be anti-aliased but have non-aa edges that are
off screen. When they are cropped, those edge flags would correctly
switch from 0 to 1.
I didn't go so far as to replace *aa with GrAA::kNo, even though the
crop to the device bounds is technically non-aa. Keeping it as *aa
increases the probability that we keep the flags as 0000 or 1111,
which are slightly faster than mixed flags. Any cropping to the
device bounds is visually the same either way since they will be
cropping to integer coords.
Bug: chromium:1196090
Change-Id: If8fc6006b5846967e33e90063f00b82b50fe61f3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/394356
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2 files changed