//gm/gm.h: Fold GM::onShortName() into GM::getName() and make it const.
This change is motivated by https://skia-review.googlesource.com/c/skia/+/741817, where I attempt to generate GM-related Gold keys from a const method in the GM class that calls GM::getName().
The original GM::getName() method returns the memoized result of GM::onShortName(). This CL eliminates the memoization as a prerequisite to marking GM::getName() as const. Given that most GMs today do simple SkString manipulations in their onShortName(), I believe this won't have any noticeable impact in performance or CQ time.
Most of the changes in this CL are the result of a simple multifile search/replace and clang-format.
Suggested review order:
- //gm/gm.h
- //gm/gm.cpp
- //gm/BazelGMRunner.cpp
- //bench/GMBench.cpp
- //modules/canvaskit/gm_bindings.cpp
- //tools/viewer/GMSlide.cpp
- //tools/viewer/Viewer.cpp
- Everything else.
Bug: b/40045301
Change-Id: Ifef0dcf6ccd4aac871e1aa6fe8342d28efcd146e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/742738
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
275 files changed