| commit | 8cdc72019dc185d68dce0a6644966bc086cd9dc9 | [log] [tgz] |
|---|---|---|
| author | John Stiles <johnstiles@google.com> | Mon May 08 11:38:39 2023 -0400 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Tue May 09 14:44:05 2023 +0000 |
| tree | 6391f097be8e9fbd7e90365ff220dc8efd51feb0 | |
| parent | 0ab87641232e0cad6f47ae05173c588942332d8b [diff] |
Remove DSL usage from RTAdjust fixup code. This makes the code a bit more bloated, but it brings us a step closer to zero DSL. When this code was originally written, it was also done without DSL. I decided to look up the old implementation out of curiosity: http://google3/third_party/skia/HEAD/src/sksl/SkSLIRGenerator.cpp?rcl=374499485&l=705 I'm biased, but I think the new version is a bit easier to follow, and the original actually mishandled VariableRefKinds (every call to Pos() was generating a write-reference). Change-Id: I6a4be0abcd7a645248eaee706a567ee5ab1f2a29 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/694576 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>