Add no-child limitation to SupportsConstantOutputForConstantInput.
In http://review.skia.org/673657, the constant-output for constant-
input optimization was removed from GrSkSLFP when the FP has children,
because in practice, we never actually applied this optimization when
children were present. However, SupportsConstantOutputForConstantInput
would still return true.
This CL fixes SupportsConstantOutputForConstantInput to return false
in this case, and also updates two internal FPs which have children
but asserted that this optimization would be valid (despite never
_actually_ leveraging the optimization in practice).
(Realistically, `GrColorFragmentProcessorAnalysis` has not been
very effective since FPs were restructured from a linked list into
a tree. It was never reworked to search inside the FP tree past
the top node.)
Change-Id: Iae2edc3327f284f4285715bd0ca2f8810bbe3d66
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/674056
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
4 files changed