commit 4a947d264b2764685e5f82b2e5d328a50e9612ea
author senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Mon Jul 18 21:48:35 2011 +0000
committer senorblanco@chromium.org <senorblanco@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Mon Jul 18 21:48:35 2011 +0000
tree 2e2b1e98a12007bb1d9957621868409c671582be
parent ef427d47128ef03c28a4d38d3f91d0d5a11115bb

Fix kernel width calculation in GPU-based Gaussian blur.  When converting the
sigma value to a kernel width, it should be rounded up.  Otherwise, for small
sigmas, the edge pixels of the kernel may be missing.



git-svn-id: http://skia.googlecode.com/svn/trunk@1891 2bbb7eff-a529-9590-31e7-b0007b416f81

samplecode/SampleBigBlur.cpp

diff --git a/samplecode/SampleBigBlur.cpp b/samplecode/SampleBigBlur.cpp
index 243e0df..aa5dc28 100644
--- a/samplecode/SampleBigBlur.cpp
+++ b/samplecode/SampleBigBlur.cpp
@@ -28,7 +28,7 @@
             SkBlurMaskFilter::kHighQuality_BlurFlag);
         paint.setMaskFilter(mf)->unref();
         canvas->translate(200, 200);
-        canvas->drawCircle(100, 100, 250, paint);
+        canvas->drawCircle(100, 100, 200, paint);
         canvas->restore();
     }
 

src/gpu/SkGpuDevice.cpp

diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp
index 513b5bb..90ab4bb 100644
--- a/src/gpu/SkGpuDevice.cpp
+++ b/src/gpu/SkGpuDevice.cpp
@@ -865,7 +865,7 @@
         sigma *= 0.5f;
     }
     scaleRect(&srcRect, 1.0f / scaleFactor);
-    int halfWidth = static_cast<int>(sigma * 3.0f);
+    int halfWidth = static_cast<int>(ceilf(sigma * 3.0f));
     int kernelWidth = halfWidth * 2 + 1;
 
     SkIRect srcIRect;