commit 66070a527c480d1cef5f7f7136f68d4f17b68f06
author junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Tue May 28 17:39:08 2013 +0000
committer junov@chromium.org <junov@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Tue May 28 17:39:08 2013 +0000
tree 5e8c8779673d7d012a825ab37caea551c37c2a80
parent bb6a3178c3e79c8549b332e4ce84c64b59964f1e

Changing SkDeferredCanvas to use factories for creation

The objective of this change is to remove all calls to 
SkCanvas::setDevice. The factory API is hidden behind
a build flag in order to ease the roll into chromium.

A side-effect of the factory pattern is that it will
no longer be possible to allocate a SkDeferredCanvas on
the stack.  This changes nothing for chrome, but it
impacts skia test programs.

Review URL: https://codereview.chromium.org/16040002

git-svn-id: http://skia.googlecode.com/svn/trunk@9298 2bbb7eff-a529-9590-31e7-b0007b416f81

bench/benchmain.cpp

diff --git a/bench/benchmain.cpp b/bench/benchmain.cpp
index 543da27..4d385a2 100644
--- a/bench/benchmain.cpp
+++ b/bench/benchmain.cpp
@@ -820,7 +820,12 @@
                 switch(benchMode) {
                     case kDeferredSilent_benchModes:
                     case kDeferred_benchModes:
-                        canvas = new SkDeferredCanvas(device);
+                        canvas = 
+#if SK_DEFERRED_CANVAS_USES_FACTORIES
+                            SkDeferredCanvas::Create(device);
+#else
+                            SkNEW_ARGS(SkDeferredCanvas, (device));
+#endif
                         break;
                     case kRecord_benchModes:
                         canvas = pictureRecordTo.beginRecording(dim.fX, dim.fY,