| commit | 8f8c2cfa4f935f99be0da61b528e9ce38d7fc89f | [log] [tgz] |
|---|---|---|
| author | Kevin Lubick <kjlubick@google.com> | Tue Oct 11 08:06:15 2022 -0400 |
| committer | Kevin Lubick <kjlubick@google.com> | Tue Oct 11 12:28:38 2022 +0000 |
| tree | e1d99ae96d877e9347c845fdb5da5ddfb5118769 | |
| parent | 1ca12f658afbb0770013a9f5e5ee057d4a7dab85 [diff] |
Make git-sync-deps fail if any git clone failed Python's Thread.join() does not fail if the thread threw an exception. This means if we failed to clone a git repo, the script would not return 0 and follow-on commands would try to do work (and fail for mysterious reasons). In Python 3.8, there is a mechanism to know if any threads threw exceptions. https://docs.python.org/3/library/threading.html#threading.excepthook I'm not 100% sure if using the anything_failed variable like this is save, but given that we are only writing one value, a data race is probably not a big deal. Change-Id: I9669bfa42b168f6159d59f46840a70f6acab64ce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/589411 Reviewed-by: Ravi Mistry <rmistry@google.com>