| commit | 05a4b12dbdf279280c691be0ccf31b718bde10c7 | [log] [tgz] |
|---|---|---|
| author | Michael Ludwig <michaelludwig@google.com> | Thu Feb 17 11:45:22 2022 -0500 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Thu Feb 17 17:44:15 2022 +0000 |
| tree | 208787a58e951a5bbd683576b75a3f4666e92769 | |
| parent | 832b9ac092eff226a606c54bab55fe949a287db8 [diff] |
Don't dither const shaders that don't have a GP override https://gold.skia.org/detail?test=gradients_no_texture&digest=008c796df4da7fbb6718e96db2c36c90 If paintFP was only non-null because it came from the main SkShader, we should defer to SkPaintPriv's check that the shader is not a constant. We don't have a isConstant() for FPs so this assumes that if the GP overrides it with a new FP it probably is doing something spatially interesting and does need the dithering. Bug: skia:12516 Change-Id: I7935ba8f0baf91e7b7ba07280452871c60ffd3e8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/509996 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>