| commit | 1fa54044efa81967c3b5acb03427a37575ce65e5 | [log] [tgz] |
|---|---|---|
| author | Bryce Thomas <bryct@amazon.com> | Tue Jan 14 13:46:30 2020 -0800 |
| committer | Kevin Lubick <kjlubick@google.com> | Wed Jan 15 14:48:36 2020 +0000 |
| tree | 859127f55e4427f4d33451ba547519dd3bba526d | |
| parent | a4f218dd683aae82179708c3cb24e6515c57d6da [diff] |
rm CanvasKit.HEAPU8.buffer caching (fix UAF bug). Cached references to the WASM heap buffer are invalid following memory growth: https://github.com/emscripten-core/emscripten/issues/6747#issuecomment-400081465. This change replaces references to the cached CanvasKit.buffer with direct references to CanvasKit.HEAPU8.buffer. The symptom of this bug is a Javascript error thrown in the Chrome console: "Uncaught TypeError: Cannot perform Construct on a neutered ArrayBuffer", causing the operation in question to fail. Bug: NONE Change-Id: I27462e80db1d33e0e77ee7295b25039c9036d2e2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/264477 Reviewed-by: Kevin Lubick <kjlubick@google.com>