Reland "[skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls"
This reverts commit 7675f886f884539c4df799a5a627b08c75365780.
Reason for revert: fixed calculation of output bounds to *before* applying the legacy tile mode; otherwise legacy tiling would flood out infinitely like the correct new tiling, but that breaks the expected behavior of the legacy tiling (hence flutter failures).
Also brings back the GrRecordingContext* field and getContext()
function on skif::Context so that the guarded code in
SkBlurImageFilter can compile in g3 and chromium.
Original change's description:
> Revert "[skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls"
>
> This reverts commit 2c34fef95166988ea68f733cd7ba890c06a6df3c.
>
> Reason for revert: some of the deleted APIs in this CL are still being used in the old blur code. must wait for g3 and chromium to finish staging.
>
> Original change's description:
> > [skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls
> >
> > This prepares the stage to do three things:
> > 1. Have the graphite backend able to write graphite shader code.
> > 2. Be a staging/testing ground for using the blur engine API (each of the blur image functors could be the basis for each
> > backend's engine impl).
> > 3. Have blurs avoid resolving the tile mode and transform on the input
> > and deferring the upscale on the output-side.
> >
> > Bug: b/294102906
> > Change-Id: I7ac576d1951ea25bae64d745ebd5f73247155e4f
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/746817
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
>
> Bug: b/294102906
> Change-Id: I4eff832691c9e74182ecad4a5bcdc64fdaf0b8af
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748856
> Auto-Submit: Michael Ludwig <michaelludwig@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: b/294102906
Change-Id: I2f656dcf4133eddf251add159e8829c7d708fcad
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/749016
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
6 files changed