| commit | dc6cc023adbfec496e4dfdcbc38022c4079c2d0b | [log] [tgz] |
|---|---|---|
| author | Kevin Lubick <kjlubick@google.com> | Fri Jan 13 11:24:27 2023 -0500 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Fri Jan 13 17:41:44 2023 +0000 |
| tree | c0ed29466380d9a83db853abed820aabc5971fbc | |
| parent | 7d27b3d0d2ab4055696fdecc9e462bd4c09c8277 [diff] |
[base] Move many files into base Moved from include/private into include/private/base: - SkAlignedStorage.h - SkContainers.h - SkFloatBits.h - SkPathEnums.h - SkTArray.h - SkTDArray.h - SkTypeTraits.h - SkVx.h - SkCPUTypes.h* Moved from include/core into include/private/base: - SkMath.h - SkSpan.h We still want SkSpan.h to be a part of the public API, so include/core/SkSpan.h still exists, it just includes include/private/base/SkSpan_impl.h We want to remove SkMath.h from the public API (most client uses have been removed already), but for now it too has a shim header file in include/core/SkMath.h As per the design of base, there are no includes inside of base on Skia files not also in base. SkLeftShift moved out of SkTypes.h and into SkMath.h, as that seemed like a better fit. U8CPU and U16CPU moved into their own file, SkCPUTypes.h while we decide where their future lies. Suggested review order: - include/private/base/BUILD.bazel - include/private/BUILD.bazel - include/BUILD.bazel - gn/*.gni (these are generated from the BUILD.bazel files) - BUILD.gn - public.bzl - Everything else, mostly done with find and replace and cleaned up with the rewrite_includes.py script. Change-Id: Icce0d0c445863c6908b63ec31b9595de400988dc Bug: skia:13983 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/629317 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com> Owners-Override: Kevin Lubick <kjlubick@google.com>