tree 41a3bff8b51fb8e26735ce57cffdeb6522af4179
parent 08070f6f65cfb18a196de9ad57e0dce66c92be23
author John Stiles <johnstiles@google.com> 1605630829 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1605631453 +0000

Disallow unsized array dimensions on size fields past the frontmost.

This was slightly complicated by the fact that this syntax indicates an
array with a known size:

    float[] x = float[](1, 2, 3, 4);

Of course, the size is 4; it's just never explicitly stated in the
code. (The SkSL parser never actually deduces the size, but it doesn't
apparently have a need to; we don't do much in the way of optimization
for arrays.) However, this prevents us from simply failing whenever we
parse "[]" in non-builtin code; we need to keep scanning and see if the
variable is initialized. We already check this in the
ArrayConstructors.sksl test file.

Change-Id: I5b86958e81bd9bf5edf28a617cecf95c1875583e
Bug: skia:10957
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335240
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>