633d8e12c15128fde3b41d6139273fdfd7625716 - platform_frameworks_base

commit	633d8e12c15128fde3b41d6139273fdfd7625716	[log] [tgz]
author	Kevin Han <kevhan@google.com>	Mon Oct 25 20:23:50 2021 -0700
committer	Kevin Han <kevhan@google.com>	Thu Oct 28 15:36:30 2021 -0700
tree	04060880fd8c3010c17e4b81392faf7d6bf32496
parent	11d1f6035db05f4e3aab28f3198bb88bf51950a0 [diff]

Exempt hibernating apps from dex optimization

We previously only checked whether an app could be optimized in
PackageManagerService#getOptimizablePackages. This missed edge cases
where the app would still generate vdex/odex such as when the app is
updated.

We fix this by considering any hibernating app as not optimizable in all
cases.

To support unit testing, we also change canOptimizePackage to a
non-static method and enumerate PackageDexOptimizer's dependencies
clearly with an injector.

Bug: 203693378
Test: Reproduce steps in bug, confirm app does not have vdex/odex
Test: atest PackageManagerServiceHibernationTests
Change-Id: I16e76619e15351659a4f7121fc17cc46937f3591

services/core/java/com/android/server/apphibernation/AppHibernationManagerInternal.java[diff]
services/core/java/com/android/server/apphibernation/AppHibernationService.java[diff]
services/core/java/com/android/server/pm/DexOptHelper.java[diff]
services/core/java/com/android/server/pm/OtaDexoptService.java[diff]
services/core/java/com/android/server/pm/PackageDexOptimizer.java[diff]
services/tests/mockingservicestests/src/com/android/server/pm/PackageManagerServiceHibernationTests.kt[diff]

6 files changed