Retain empty shade visibility on reinflation
Previously, the visibility was being reset to false whenever the empty
shade was re-inflated. This was wrong even with the footer refactor flag
off, but since we were callin updateEmptyShadeView more often it was
very unlikely to actually cause issues. With the refactor we were only
updating the visibility when it actually changed, so the (already
somewhat flaky) testEmptyShade test started failing much more
consistently.
This was hard to catch also due to the fact that the helper method used
inside updateEmptyShadeView to update the view resources was also called
updateEmptyShadeView, so at first glance it seemed like the view was
being correctly updated on reinflation. Renamed the helper method now to
avoid further confusion.
Fix: 328335095
Test: platinum tests
Flag: NONE
Change-Id: I1b62b24a2166f932c801de461bd401e5ae5a8911
1 file changed