AAPT2: Separate out the various steps
An early refactor. Some ideas became clearer as
development continued. Now the various phases are much
clearer and more easily reusable.
Also added a ton of tests!
Change-Id: Ic8f0a70c8222370352e63533b329c40457c0903e
diff --git a/tools/aapt2/StringPool_test.cpp b/tools/aapt2/StringPool_test.cpp
index 9552937..c722fbe 100644
--- a/tools/aapt2/StringPool_test.cpp
+++ b/tools/aapt2/StringPool_test.cpp
@@ -15,7 +15,7 @@
*/
#include "StringPool.h"
-#include "Util.h"
+#include "util/Util.h"
#include <gtest/gtest.h>
#include <string>
@@ -67,15 +67,23 @@
TEST(StringPoolTest, PruneStringsWithNoReferences) {
StringPool pool;
+ StringPool::Ref refA = pool.makeRef(u"foo");
{
StringPool::Ref ref = pool.makeRef(u"wut");
EXPECT_EQ(*ref, u"wut");
- EXPECT_EQ(1u, pool.size());
+ EXPECT_EQ(2u, pool.size());
}
+ StringPool::Ref refB = pool.makeRef(u"bar");
- EXPECT_EQ(1u, pool.size());
+ EXPECT_EQ(3u, pool.size());
pool.prune();
- EXPECT_EQ(0u, pool.size());
+ EXPECT_EQ(2u, pool.size());
+ StringPool::const_iterator iter = begin(pool);
+ EXPECT_EQ((*iter)->value, u"foo");
+ EXPECT_LT((*iter)->index, 2u);
+ ++iter;
+ EXPECT_EQ((*iter)->value, u"bar");
+ EXPECT_LT((*iter)->index, 2u);
}
TEST(StringPoolTest, SortAndMaintainIndexesInReferences) {