tree fbfbd2cee2d0bbceb0d1d61e3dd81c1c3636fe0b
parent c5ae4b9e4d00fc5f8fca1bd0e95a26f5033a65c8
author Winson Chiu <chiuwinson@google.com> 1652370231 +0000
committer Winson Chiu <chiuwinson@google.com> 1652376610 +0000

Fix PMS recordInitialState on retry

Need to recapture the initial state so that the retry on the
implementation lambda works as expected. Otherwise it will compare
a stale, always broken state on the retry.

Also adds a safety check in the commitStateMutation method to see
if the calling thread already has mLock. If it does, the state change
check can be skipped since no snapshot changes can come in while the
lock is held.

Bug: 232061163

Test: atest android.packageinstaller.install.cts.SessionTest#setAppCategory

Change-Id: I78cd6a32782ee64a705ba5faa6a72a7bf8a95f03