42c91ffaec9ea106f0b6fc031a860f0cbc029545 - platform_frameworks_base

commit	42c91ffaec9ea106f0b6fc031a860f0cbc029545	[log] [tgz]
author	Dave Mankoff <mankoff@google.com>	Tue May 25 16:29:36 2021 -0400
committer	Dave Mankoff <mankoff@google.com>	Tue May 25 16:33:06 2021 -0400
tree	324a7918528b4e7b9a5f72bbc1a539e6cab5fc48
parent	dff37ee6d22b24055d2d2bd9e2bb7f3e2f8f60bc [diff]

Break VolumeDialogControllerImpl' dependency on StatusBar

VolumeDialogControllerImpl had a reference to a lazy StatusBar.
Because of how it was used, this could result in trying to stand up
StatusBar (and all of its dependencies) on a non-main thread, which
they did not appreciate.

This removes the dependency on StatusBar, and throws in a healthy
dash of dependency injection while we're at it.

Fixes: 189203821
Test: atest SystemUITests && manual
Change-Id: I41e00438b30928815e9355162af05f926f24dfce

packages/SystemUI/src/com/android/systemui/ScreenDecorations.java[diff]
packages/SystemUI/src/com/android/systemui/dagger/FrameworkServicesModule.java[diff]
packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarSignalPolicy.java[diff]
packages/SystemUI/src/com/android/systemui/util/concurrency/ThreadFactory.java[diff]
packages/SystemUI/src/com/android/systemui/util/concurrency/ThreadFactoryImpl.java[diff]
packages/SystemUI/src/com/android/systemui/volume/VolumeDialogControllerImpl.java[diff]
packages/SystemUI/tests/src/com/android/systemui/util/concurrency/FakeThreadFactory.java[diff]
packages/SystemUI/tests/src/com/android/systemui/volume/VolumeDialogControllerImplTest.java[diff]

8 files changed