commit 2ccb5030c691849c1dfadf9c7136b7fc18acab9c
author Fred Fettinger <fettinge@motorola.com> Wed Jul 01 16:43:48 2015 -0500
committer John Reck <jreck@google.com> Thu Jul 30 13:03:00 2015 -0700
tree 4838ccbdea6e61a69e8a5403352d8c9e2d303a9c
parent cef25e5319e4f76682dd63a3c01bfacb19aeeb51

animateNoDamage failed to remove from current frame list

runRemainingAnimations is used to animate the available animation handle
which were not yet run, it actually animate those animation handle and
removes from the list by notifyAnimationsRan(). In case if these animation
handles are not removed, it leads to the Fatal Assert of runRemainingAnimations.

Some usecases causes the addition of animation handle when there is
no animators, in these cases this check prevents execution of
notifyAnimationsRan() leads to Fatal Assert crash of runRemainingAnimations.

Allowing the animation to happen irrespective of animators solves the problem

Change-Id: I685dc7ebf736268927a536595910fc63353306eb
Signed-off-by: Parasuraman <parasur@motorola.com>
Signed-off-by: Fred Fettinger <fettinge@motorola.com>

libs/hwui/AnimatorManager.cpp

diff --git a/libs/hwui/AnimatorManager.cpp b/libs/hwui/AnimatorManager.cpp
index 0dababd..cd30b18 100644
--- a/libs/hwui/AnimatorManager.cpp
+++ b/libs/hwui/AnimatorManager.cpp
@@ -124,8 +124,6 @@
 }
 
 void AnimatorManager::animateNoDamage(TreeInfo& info) {
-    if (!mAnimators.size()) return;
-
     animateCommon(info);
 }
 
@@ -169,7 +167,7 @@
 };
 
 void AnimatorManager::endAllActiveAnimators() {
-    ALOGD("endAllStagingAnimators on %p (%s) with handle %p",
+    ALOGD("endAllActiveAnimators on %p (%s) with handle %p",
             &mParent, mParent.getName(), mAnimationHandle);
     EndActiveAnimatorsFunctor functor(mAnimationHandle->context());
     for_each(mAnimators.begin(), mAnimators.end(), functor);