usb: Use Get/SetByteArrayRegion in bulkTransfer
This change fixes https://issuetracker.google.com/issues/335003907
This change replaces
GetPrimitiveArrayCritical/ReleasePrimitiveArrayCritical with
GetByteArrayRegion/SetByteArrayRegion.
This change is needed because the critical API variants are not
appropriate for this context. See the JNI docs:
After calling GetPrimitiveArrayCritical, the native code should not run
for an extended period of time before it calls
ReleasePrimitiveArrayCritical.
In bulkTransfer, we call usb_device_bulk_transfer between
GetPrimitiveArrayCritical/ReleasePrimitiveArrayCritical.
usb_device_bulk_transfer is a blocking call so this can lead to GC
hangs.
Instead, we allocate a new buffer with malloc and then call
GetByteArrayRegion/SetByteArrayRegion before/after
usb_device_bulk_transfer, depending on the direction of the endpoint.
Test: I ran UsbTests. I also sent a "TEST UNIT READY" to a USB drive and
verified the response.
Change-Id: I5c82aac3fe99e1f11044f20091bf3a940bc8f6a7
1 file changed