Remove useless open modes
Open modes are ignored if the user doesn't want the file to be created:
http://man7.org/linux/man-pages/man2/open.2.html
Since it's somewhat misleading/potentially indicative of a missing
O_CREAT/O_TMPFILE, we plan to issue a warning on open calls with useless
mode bits in the near future. Because -Werror is used in this project
(thank you!), we need to either make these modes useful, or remove them.
Bug: 64132680
Test: mma. New warnings no longer appear.
Change-Id: I5d9b98152e48135ea716592b28c5c771cc74018b
diff --git a/cmds/incidentd/src/Section.cpp b/cmds/incidentd/src/Section.cpp
index 8494f98..ddb54c1 100644
--- a/cmds/incidentd/src/Section.cpp
+++ b/cmds/incidentd/src/Section.cpp
@@ -122,7 +122,7 @@
// read from mFilename and pump buffer to incident_helper
status_t err = NO_ERROR;
- int fd = open(mFilename, O_RDONLY, 0444);
+ int fd = open(mFilename, O_RDONLY);
if (fd == -1) {
ALOGW("FileSection '%s' failed to open file", this->name.string());
return -errno;