tree 7929e2efb03b538290076446d2452e5c90a9c628
parent 226eadbeddce4ad4d9e6cc06d5e4da1b64cb0ae4
author Seigo Nonaka <nona@google.com> 1500348164 -0700
committer android-build-team Robot <android-build-team-robot@google.com> 1500516063 +0000

Fix race condition of removing surface.

mContainer.startingSurface can be replaced between posting
mRemoveStartingWindow and actually surface.remove() is called.

1. removeStartingWindow is called, then mRemoveStartingWindow is posted
   to mHandler
2. transferStartingWindow is called, then mContainer.startingWindow is
   replaced with new surface.
3. mHandler pops the callback and surface.remove() is called.

Here the remove is only called for replaced surface and never called for
older surface.

To fix this issue, surely removes the surface when the
removeStartingWindow is called.

Bug: 63156080
Bug: 63784898
Test: Watch /proc/<pid>/fd
Change-Id: I55e2c1b8fba32b3a19603e6ad4743f07576abd48
(cherry picked from commit 82871bdcfcc250e4aeeb731dfedeb0a23623244a)