commit 5f9e3a0dc6566f6270005ffc3c9b5477121f2ca2
author Alex Buynytskyy <alexbuy@google.com> Tue Apr 07 21:13:41 2020 -0700
committer Alex Buynytskyy <alexbuy@google.com> Tue Apr 07 21:13:41 2020 -0700
tree ea5d67528228b43717408f1fabb6c94f441fd746
parent f41567922839d9e84fad0333788301b6c2b330de

Uninitialized member fix :(

Bug: b/153468113
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ida26dc1476c2b329f9aba4d605e65c43e2cafac2

services/incremental/IncrementalService.cpp

diff --git a/services/incremental/IncrementalService.cpp b/services/incremental/IncrementalService.cpp
index d6ce529..bca21cd 100644
--- a/services/incremental/IncrementalService.cpp
+++ b/services/incremental/IncrementalService.cpp
@@ -578,6 +578,7 @@
 int IncrementalService::setStorageParams(StorageId storageId, bool enableReadLogs) {
     const auto ifs = getIfs(storageId);
     if (!ifs) {
+        LOG(ERROR) << "setStorageParams failed, invalid storageId: " << storageId;
         return -EINVAL;
     }
 

services/incremental/IncrementalService.h

diff --git a/services/incremental/IncrementalService.h b/services/incremental/IncrementalService.h
index c2a550b..0843fde 100644
--- a/services/incremental/IncrementalService.h
+++ b/services/incremental/IncrementalService.h
@@ -160,12 +160,12 @@
     class IncrementalServiceConnector : public BnIncrementalServiceConnector {
     public:
         IncrementalServiceConnector(IncrementalService& incrementalService, int32_t storage)
-              : incrementalService(incrementalService) {}
+              : incrementalService(incrementalService), storage(storage) {}
         binder::Status setStorageParams(bool enableReadLogs, int32_t* _aidl_return) final;
 
     private:
         IncrementalService& incrementalService;
-        int32_t storage;
+        int32_t const storage;
     };
 
 private: