d066c7c93383693dcf2225db66d78b598a725d84 - platform_frameworks_base

commit	d066c7c93383693dcf2225db66d78b598a725d84	[log] [tgz]
author	Hai Zhang <zhanghai@google.com>	Fri Jan 15 14:35:10 2021 -0800
committer	Hai Zhang <zhanghai@google.com>	Thu Jan 21 13:55:56 2021 -0800
tree	dfd599f31616412368e6b36a966864df14e0b6f4
parent	91464139ff9518217fecd4946753dfdcad3225b5 [diff]

Move computePackageStateHash() implementation into platform.

The computePackageStateHash() implementation needs
PackageManagerInternal.forEachInstalledPackage(),
getApplicationEnabledState(), getEnabledComponents() and
getDisabledComponents() to work, for which we don't have good
alternatives in API. Even if we added those APIs, generating and
iterating over PackageInfo for all packages in the system would surely
drive up CPU and memory usage and regress our performance, and the new
AndroidPackage system APIs isn't ready in S yet. So we can move
computePackageStateHash() implementation into platform. Once we move
role logic into system server, granting default roles may be fast
enough and we may consider the deprecation/removal of this.

This way we can also remove the final dependency we have on
PackageManagerInternal and be ready for modularization.

Bug: 158736025
Test: presubmit
Change-Id: I14119f2e95c861ee3539108748a4912b051b4462

services/core/java/com/android/server/policy/role/RoleServicePlatformHelperImpl.java[Renamed from services/core/java/com/android/server/policy/role/LegacyRoleStateProviderImpl.java - diff]
services/core/java/com/android/server/role/RoleManagerService.java[diff]
services/core/java/com/android/server/role/RoleServicePlatformHelper.java[Renamed from services/core/java/com/android/server/role/LegacyRoleStateProvider.java - diff]
services/core/java/com/android/server/role/RoleUserState.java[diff]
services/java/com/android/server/SystemServer.java[diff]

5 files changed