0d51a8bcc0d5ac6dadbf242db5ce9404ca369fb2 - platform_frameworks_base

commit	0d51a8bcc0d5ac6dadbf242db5ce9404ca369fb2	[log] [tgz]
author	Suprabh Shukla <suprabh@google.com>	Wed Oct 30 18:56:44 2019 -0700
committer	Suprabh Shukla <suprabh@google.com>	Mon Nov 04 11:59:36 2019 -0800
tree	4a2229030a853f72f12eb172a62186f78c32504f
parent	c4f77faf6e2ac5ef42ed95371cb2ef16030a2b02 [diff]

Remove cancel listeners from pending intent alarms

The cancel listeners are created per PendingIntent instance and were
spamming the callback list stored inside PendingIntentRecord. In cases
where there is even a single live PendingIntent backed by this
PendingIntentRecord, all PendingIntent instances backed by this
PendingIntentRecord for which a callback was ever registered will leak.

Test: atest FrameworksMockingServicesTests:\
com.android.server.am.PendingIntentControllerTest
atest FrameworksMockingServicesTests:\
com.android.server.AlarmManagerServiceTest

Bug: 143091024
Change-Id: I65df12da0c437064e6e3719911926738c677c4eb

core/java/android/app/PendingIntent.java[diff]
services/core/java/com/android/server/AlarmManagerInternal.java[diff]
services/core/java/com/android/server/AlarmManagerService.java[diff]
services/core/java/com/android/server/am/PendingIntentController.java[diff]
services/tests/mockingservicestests/src/com/android/server/AlarmManagerServiceTest.java[diff]
services/tests/mockingservicestests/src/com/android/server/am/PendingIntentControllerTest.java[Added - diff]

6 files changed