commit 943c97a03edbe2658f7b93617d6d9561aa8c1876
author Lee Shombert <shombert@google.com> Tue Jan 12 17:08:06 2021 -0800
committer Lee Shombert <shombert@google.com> Tue Jan 12 17:08:47 2021 -0800
tree a00b4ff158b92fa69d205510737b6c9adad13172
parent a55149d940472268642dd0dd272162a3670412e1

PackageManagerService lock reduction: address comments

Bug: 161323622

Address three comments from previous commits:
 1. Change "computer(true)" to liveComputer() and "computer(false)"
    to "snapshotComputer()".  Delete the "// SNAPSHOT" comments as
    they are now unnecessary.
 2. Unit-test changes
 3. Four indentation errors that were introduced in ag/13027799.

Test: atest
 * FrameworksServicesTests:UserSystemPackageInstallerTest
 * FrameworksServicesTests:PackageManagerSettingsTests
 * FrameworksServicesTests:PackageManagerServiceTest
 * FrameworksServicesTests:AppsFilterTest
 * FrameworksServicesTests:PackageInstallerSessionTest
 * FrameworksServicesTests:ScanTests
 * FrameworksServicesTests:WatcherTest
 * UserLifecycleTests#startUser
 * UserLifecycleTests#stopUser
 * UserLifecycleTests#switchUser

Change-Id: I664666ce37f09c0ffa3ed15b8c24854f776668a4