tree b9c23302e59140517b005f1329f3948f5a447fa2
parent dd09e994f5d1a92a4a922dbc8742d0c15d9342d3
author Jorim Jaggi <jjaggi@google.com> 1503406517 +0200
committer Jorim Jaggi <jjaggi@google.com> 1503486761 +0000

Fix issue with app not becoming visible

If an activity was started on top of Keyguard but didn't have
FLAG_SHOW_WHEN_LOCKED set yet, topRunningActivityLocked was
the activity, so we called minimalResumeActivity with the activity
but the activity wasn't made visible because
checkKeyguardVisibility returned false. Then, r.visible was set
to true without actually informing window manager about the
visibility change, which wasn't corrected in
resumeTopActivityInnerLocked because r.visible was already set to
true.

Then, it's windows were stuck in READY_TO_SHOW state because the
token was never made visible.

Fix this by informing by informing WM about visibilility change in
completeResumeLocked. This is a no-op if visibility was already
correct.

I belive this regression was originally caused from
I745e985766a1af97203e1d22b6443dabdd0c0363

Test: go/wm-smoke
Test: Set dream from "Timely Alarm Clock", wait until dreaming,
then adb shell am start -n
ch.bitspin.timely/ch.bitspin.timely.activity.SnoozeActivity_

Change-Id: Idbd47086885c3536fa01ab249309ebe37203ba0b
Fixes: 62373472