1e72ef28933823594bf2b1993fed2d4895b20a67 - platform_frameworks_base

commit	1e72ef28933823594bf2b1993fed2d4895b20a67	[log] [tgz]
author	Lan Wei <azurewei@google.com>	Thu Oct 29 16:16:46 2020 +0800
committer	Lan Wei <azurewei@google.com>	Thu Oct 29 16:51:49 2020 +0800
tree	12756020359ac70e11c681d2193020ad5cee52fe
parent	64cd208bee81ee31306cf8d3c917efefd2a719e2 [diff]

Avoid bad InputConnection call crashing the app

Update InputConnection#getTextBeforeCursor(int, int) and
InputConnection#getTextAfterCursor(int, int) API to
specify that the paramter {@code n} must be non-negative.
If the IME using the API incorrectly, throw
IllegalArgumentException.

Also update these two APIs that return nullable result (no
behaivor change). For editor App, return null for bad case.

Test: atest BaseInputConnectionTest#testInvalidGetTextBeforeOrAfterCursorRequest
Test: atest InputConnectionWrapperTest#testInvalidGetTextBeforeOrAfterCursorRequest

BUG: 169114026

Change-Id: I95169735198f8363c981a61e20234dfebfd645b1

api/current.txt[diff]
core/java/android/view/inputmethod/BaseInputConnection.java[diff]
core/java/android/view/inputmethod/InputConnection.java[diff]
core/java/android/view/inputmethod/InputConnectionWrapper.java[diff]
core/java/com/android/internal/view/InputConnectionWrapper.java[diff]
non-updatable-api/current.txt[diff]

6 files changed