0447068f27f4d8c44052026878740cbcd7d598fa - platform_frameworks_base

commit	0447068f27f4d8c44052026878740cbcd7d598fa	[log] [tgz]
author	Andrii Kulian <akulian@google.com>	Wed Jan 10 15:32:31 2018 -0800
committer	Andrii Kulian <akulian@google.com>	Fri Jan 12 13:08:25 2018 -0800
tree	3c5d9c17ddc88dfb2095be845cadc8ad1a348322
parent	200cd63fb3ff5b4354773e9994f4340f18b39cbc [diff]

Fix object pool for lifecycler

The original implementation of object pool for lifecycle
transactions tried to always recycle objects after a
transaction was scheduled. In case when a client was running
in the same process this lead to objects being emptied before
it could actually perform the transaction.
Also when checking if object was already in the pool we should
use "==" instead of equality check.

Bug: 70554032
Bug: 71346774
Test: com.android.server.am.ClientLifecycleManagerTests
Test: android.app.servertransaction.ObjectPoolTests
Change-Id: I85fb3dae4589c2390e00a37144da0d285d16d151

core/java/android/app/ActivityThread.java[diff]
core/java/android/app/servertransaction/ClientTransaction.java[diff]
core/java/android/app/servertransaction/ObjectPool.java[diff]
core/tests/coretests/src/android/app/servertransaction/ObjectPoolTests.java[diff]
services/core/java/com/android/server/am/ClientLifecycleManager.java[diff]
services/tests/servicestests/src/com/android/server/am/ActivityRecordTests.java[diff]
services/tests/servicestests/src/com/android/server/am/ClientLifecycleManagerTests.java[Added - diff]

7 files changed

tree: 3c5d9c17ddc88dfb2095be845cadc8ad1a348322