Moves the settings changed logging for statsd.
Previously, we wrote a log entry regardless of permission checks, so
the logging could be misleading. Now we only send the log to statsd
after verifying that this setting mutation is valid.
Test: Flashed onto marlin-eng and verified stats-log as expected.
Bug: 73493944
Change-Id: I2a8b052aa8c380ffc5d15caec089fffcdc5823f4
diff --git a/cmds/statsd/src/atoms.proto b/cmds/statsd/src/atoms.proto
index 31ca13a..8d36936 100644
--- a/cmds/statsd/src/atoms.proto
+++ b/cmds/statsd/src/atoms.proto
@@ -1098,7 +1098,7 @@
/**
* Logs that a setting was updated.
* Logged from:
- * frameworks/base/core/java/android/provider/Settings.java
+ * frameworks/base/packages/SettingsProvider/src/com/android/providers/settings/SettingsState.java
* The tag and is_default allow resetting of settings to default values based on the specified
* tag. See Settings#putString(ContentResolver, String, String, String, boolean) for more details.
*/
@@ -1124,8 +1124,14 @@
// True if this setting with tag should be resettable.
optional bool is_default = 6;
- // The user ID associated. Defined in android/os/UserHandle.java
+ // The associated user (for multi-user feature). Defined in android/os/UserHandle.java
optional int32 user = 7;
+
+ enum ChangeReason {
+ UPDATED = 1; // Updated can be an insertion or an update.
+ DELETED = 2;
+ }
+ optional ChangeReason reason = 8;
}
/**