tree 96943a630a205e4759728f94c7812a2972d08b40
parent ef3dd32c26dd0b7162c1dc5249193faf2f5ad92d
author Hai Zhang <zhanghai@google.com> 1673059692 -0800
committer Hai Zhang <zhanghai@google.com> 1673093592 -0800

Compute PermissionInfo.FLAG_INSTALLED instead of mutating ParsedPermission.

PermissionInfo.FLAG_INSTALLED is about the current system state
instead of the permission definition itself as in its APK, so we
shouldn't be mutating the ParsedPermission object to return it.

Instead, we now follow what we did for granted permissions and gather
and pass installed permissions similarly, so that we return the right
flag in PackageInfo.permissions.

For other methods returning PermissionInfo, they are all returning
permission definitions that are registered in the system, so we can
just unconditionally add FLAG_INSTALLED to them.

This resolves the issue when the new subsystem is enabled that
PermissionController refuses to manage a permission if its definition
doesn't have FLAG_INSTALLED.

Bug: 263504888
Test: manual
Change-Id: I891fa8b3adf7095a3c09ac448e1e377d432dafdc