c36ee6f4ff07154b302f16efc9e842f01fb90dfd - platform_frameworks_base

commit	c36ee6f4ff07154b302f16efc9e842f01fb90dfd	[log] [tgz]
author	Joshua Tsuji <tsuji@google.com>	Tue May 28 17:00:16 2019 -0400
committer	Joshua Tsuji <tsuji@google.com>	Wed May 29 15:22:31 2019 -0400
tree	3330cc8a69fb0f93889b59ad7531d14beab68ed2
parent	0fa7a54e3026937528c03456287d8cb23598631d [diff]

Stability and logic fixes to PhysicsAnimationLayout to address bugs that leave Bubbles in a bad state.

- Ignore attempts to start animations from controllers that aren't the active controller.
- Use -Float.MAX_VALUE for the start velocity default, not 0, so negative velocities aren't discarded.
- Update the SpringForce's final position directly rather than using animateToFinalPosition (the latter is susceptible to race conditions if animateToFinalPosition is called again before the next animation frame, a bug in DynamicAnimation).

Test: atest SystemUITests
Fixes: 131625234
Change-Id: Ie48da88db6c241896bba17bb800a2f91ab61651e

packages/SystemUI/src/com/android/systemui/bubbles/BubbleStackView.java[diff]
packages/SystemUI/src/com/android/systemui/bubbles/animation/ExpandedAnimationController.java[diff]
packages/SystemUI/src/com/android/systemui/bubbles/animation/PhysicsAnimationLayout.java[diff]
packages/SystemUI/src/com/android/systemui/bubbles/animation/StackAnimationController.java[diff]
packages/SystemUI/tests/src/com/android/systemui/bubbles/animation/ExpandedAnimationControllerTest.java[diff]
packages/SystemUI/tests/src/com/android/systemui/bubbles/animation/PhysicsAnimationLayoutTest.java[diff]
packages/SystemUI/tests/src/com/android/systemui/bubbles/animation/PhysicsAnimationLayoutTestCase.java[diff]
packages/SystemUI/tests/src/com/android/systemui/bubbles/animation/StackAnimationControllerTest.java[diff]

8 files changed