a4664b66a3ea8f50b570e7bbf7bb34f04fa02439 - platform_frameworks_base

commit	a4664b66a3ea8f50b570e7bbf7bb34f04fa02439	[log] [tgz]
author	mattgilbride <mattgilbride@google.com>	Thu Jul 28 19:07:25 2022 +0000
committer	mattgilbride <mattgilbride@google.com>	Tue Aug 16 10:50:24 2022 +0000
tree	ccb390aaa94dfbb8ad02128c172193a8a200ddf8
parent	2a7eb38239d2cb33d5a05a9e45dd47c171507376 [diff]

Add ManualPermissionCheckDetector

This linter looks at methods that implement an AIDL interface.
If a given method contains a simple permission check, it suggests
moving that check to an @EnforcePermission annotation. The intent
is to keep as many permission checks as possible at a lower-level
to the service implementation, thus mitigating permission bypass
vulnerabilities.

Also rearranges some helpers/constants for reuse, and moves everything related to aidl to its own package.

Test: atest ManualPermissionCheckDetectorTest --host
Bug: 232058525
Change-Id: Ie6eaf061d74bd773742aa47f731e95e4b137f438

tools/lint/checks/src/main/java/com/google/android/lint/AndroidFrameworkIssueRegistry.kt[diff]
tools/lint/checks/src/main/java/com/google/android/lint/Constants.kt[Added - diff]
tools/lint/checks/src/main/java/com/google/android/lint/PackageVisibilityDetector.kt[diff]
tools/lint/checks/src/main/java/com/google/android/lint/aidl/Constants.kt[Added - diff]
tools/lint/checks/src/main/java/com/google/android/lint/aidl/EnforcePermissionDetector.kt[Renamed from tools/lint/checks/src/main/java/com/google/android/lint/EnforcePermissionDetector.kt - diff]
tools/lint/checks/src/main/java/com/google/android/lint/aidl/EnforcePermissionFix.kt[Added - diff]
tools/lint/checks/src/main/java/com/google/android/lint/aidl/ManualPermissionCheckDetector.kt[Added - diff]
tools/lint/checks/src/main/java/com/google/android/lint/model/Method.kt[Added - diff]
tools/lint/checks/src/test/java/com/google/android/lint/aidl/EnforcePermissionDetectorTest.kt[Renamed from tools/lint/checks/src/test/java/com/google/android/lint/EnforcePermissionDetectorTest.kt - diff]
tools/lint/checks/src/test/java/com/google/android/lint/aidl/ManualPermissionCheckDetectorTest.kt[Added - diff]

10 files changed