commit d395f7913336417bcbbea740fcdc8589789626bc
author Dan Albert <danalbert@google.com> Mon Oct 20 14:44:39 2014 -0700
committer Dan Albert <danalbert@google.com> Mon Oct 20 14:45:55 2014 -0700
tree e1f6abf7cc604e064f9f1168e583d28752eec1b2
parent 4cd671e4d27befdd576fa86051956c3cafad6808

Fix an overflow found by ASAN.

Sometimes len is 0.

Change-Id: I031000188edc57663a5519b00cbbb751600d32f4

tools/aapt/Resource.cpp

diff --git a/tools/aapt/Resource.cpp b/tools/aapt/Resource.cpp
index 6ebf41f1..cc9207d 100644
--- a/tools/aapt/Resource.cpp
+++ b/tools/aapt/Resource.cpp
@@ -553,7 +553,7 @@
                     String8(parser.getElementName(&len)).string(), attr);
             return ATTR_LEADING_SPACES;
         }
-        if (str[len-1] == ' ') {
+        if (len != 0 && str[len-1] == ' ') {
             fprintf(stderr, "%s:%d: Tag <%s> attribute %s can not end with a space.\n",
                     path.string(), parser.getLineNumber(),
                     String8(parser.getElementName(&len)).string(), attr);