3b5a09c14c631ed64239baaadb4919d1dd46431d - platform_frameworks_base

commit	3b5a09c14c631ed64239baaadb4919d1dd46431d	[log] [tgz]
author	Nikolas Havrikov <havrikov@google.com>	Wed Dec 22 15:02:39 2021 +0100
committer	Nikolas Havrikov <havrikov@google.com>	Tue Jan 04 17:53:54 2022 +0100
tree	5b50683498d26b0031e5dd50520f258f07a5ff86
parent	f724ab4719a0ca1d9f66be026e0440da3dc20273 [diff]

Refactor locking in input method framework

This CL introduces a static global lock ImfLock.class to be used
instead of the mMethodMap. This allows to avoid erroneous warnings
from the errorprone checker.

Also, this CL fixes some cases, in which locked resources were
accessed without holding the appropriate lock.

Bug: 205676419
Test: atest CtsInputMethodTestCases
Test: RUN_ERROR_PRONE=true m services  -j | grep -e InputMethod | grep GuardedBy
Change-Id: If50984d23410b11eb5f8ae731e1c0c5ca92447c6

services/core/java/com/android/server/inputmethod/ImfLock.java[Added - diff]
services/core/java/com/android/server/inputmethod/InputMethodBindingController.java[diff]
services/core/java/com/android/server/inputmethod/InputMethodManagerService.java[diff]
services/core/java/com/android/server/inputmethod/InputMethodMenuController.java[diff]
services/core/java/com/android/server/inputmethod/InputMethodSubtypeSwitchingController.java[diff]

5 files changed