commit c7c6a4ac12beb7c216076958612869426da06da0
author Cody Kesting <ckesting@google.com> Thu Mar 05 10:46:02 2020 -0800
committer Cody Kesting <ckesting@google.com> Mon Mar 30 11:10:46 2020 -0700
tree 6afa16d1a53cb82b0a93f0feff17c1c519e9c0ae
parent 662076b1a7c0f064fa746fc7b8d3204c966c8e48

Use IBinder as key for ConnectivityDiagnostics storage in CS.

This change updates ConnectivityService to use IBinder instances as keys
when storing ConnectivityDiagnosticsCallbacks.

When storing ConnectivityDiagnosticsCallbacks in ConnectivityService,
the IConnectivityDiagnsoticsCallback is used as the key for
ConnectivityService.mConnectivityDiagnosticsCallbacks. However,
IConnectivityDiagnosticsCallback instances are received as different
objects. This causes them to produce different hashCode() values, so
attempts to remove an IConnectivityDiagnosticsCallback fail.

Bug: 150867635
Test: atest FrameworksNetTests
Change-Id: Ib99e68d5ae47fa27e12428f9a60a2c1204ac59a2