| commit | 1c08f4825334622ee90331372f68319feb2fa68d | [log] [tgz] |
|---|---|---|
| author | Jeff Sharkey <jsharkey@android.com> | Fri Oct 16 17:14:33 2020 -0600 |
| committer | Jeff Sharkey <jsharkey@android.com> | Tue Oct 20 22:00:16 2020 -0600 |
| tree | 9a08184859dd0ad17632f2ae9c8619a7c9ceb8d0 | |
| parent | df8dc2b4a5520784362804ce8e04afa53a0ca613 [diff] |
Apply fixes for EfficientStringsChecker. The recently-built Error Prone checker has found many instances where we're always paying the cost of StringBuilder concatenation, even in the typical cases where preconditions are successfully met. Benchmarks have shown that even when replacing these with varargs formatter strings, the default case is 20x faster. Bug: 170978902 Test: none Exempt-From-Owner-Approval: trivial refactoring Change-Id: If8c00bc73467bfb91ec16c162969c9d26ca53646