commit 7f94e9fe00a97d355d308622da7ab3f787318226
author Jeff DeCew <jeffdq@google.com> Fri Jul 07 12:56:13 2023 -0400
committer Jeff DeCew <jeffdq@google.com> Wed Jul 19 13:08:59 2023 +0000
tree b3d6f76d68577313e4fe555e40b0c51d630dd47b
parent c44cfb9c7ffb2e45243454931a9fd6594e55db09

Promote FeatureFlag best practices in notifications code & tests

* Introduces a ViewRefactorFlag object which:
  * Avoids bugs from boolean flag fields in views being uninitialized
  * Provides helpers for asserting & checking the flag state
* Removes FeatureFlags from AmbientState
* Changes all uses of FeatureFlags mocks in com.android.systemui.statusbar.notification tests to FakeFeatureFlags
* Changes NotificationTestHelper to use constructor-provided FakeFeatureFlags; removes setter

Fixes: 290365128
Test: atest SystemUITests
Change-Id: Id16e9f59b800601dc04892477ede748c6ea2a8d3