Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "ResourceParser.h" |
| 18 | #include "ResourceTable.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 19 | #include "ResourceUtils.h" |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 20 | #include "ResourceValues.h" |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 21 | #include "test/Test.h" |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 22 | #include "xml/XmlPullParser.h" |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 23 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 24 | #include <sstream> |
| 25 | #include <string> |
| 26 | |
| 27 | namespace aapt { |
| 28 | |
| 29 | constexpr const char* kXmlPreamble = "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n"; |
| 30 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 31 | TEST(ResourceParserSingleTest, FailToParseWithNoRootResourcesElement) { |
| 32 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().build(); |
| 33 | std::stringstream input(kXmlPreamble); |
| 34 | input << "<attr name=\"foo\"/>" << std::endl; |
| 35 | ResourceTable table; |
| 36 | ResourceParser parser(context->getDiagnostics(), &table, Source{ "test" }, {}); |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 37 | xml::XmlPullParser xmlParser(input); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 38 | ASSERT_FALSE(parser.parse(&xmlParser)); |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 39 | } |
| 40 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 41 | struct ResourceParserTest : public ::testing::Test { |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 42 | ResourceTable mTable; |
| 43 | std::unique_ptr<IAaptContext> mContext; |
| 44 | |
| 45 | void SetUp() override { |
| 46 | mContext = test::ContextBuilder().build(); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 47 | } |
| 48 | |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 49 | ::testing::AssertionResult testParse(const StringPiece& str) { |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 50 | return testParse(str, ConfigDescription{}); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 51 | } |
| 52 | |
| 53 | ::testing::AssertionResult testParse(const StringPiece& str, const ConfigDescription& config) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 54 | std::stringstream input(kXmlPreamble); |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 55 | input << "<resources>\n" << str << "\n</resources>" << std::endl; |
Adam Lesinski | 9f22204 | 2015-11-04 13:51:45 -0800 | [diff] [blame] | 56 | ResourceParserOptions parserOptions; |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 57 | ResourceParser parser(mContext->getDiagnostics(), &mTable, Source{ "test" }, config, |
Adam Lesinski | 9f22204 | 2015-11-04 13:51:45 -0800 | [diff] [blame] | 58 | parserOptions); |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 59 | xml::XmlPullParser xmlParser(input); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 60 | if (parser.parse(&xmlParser)) { |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 61 | return ::testing::AssertionSuccess(); |
| 62 | } |
| 63 | return ::testing::AssertionFailure(); |
| 64 | } |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 65 | }; |
| 66 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 67 | TEST_F(ResourceParserTest, ParseQuotedString) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 68 | std::string input = "<string name=\"foo\"> \" hey there \" </string>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 69 | ASSERT_TRUE(testParse(input)); |
| 70 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 71 | String* str = test::getValue<String>(&mTable, "string/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 72 | ASSERT_NE(nullptr, str); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 73 | EXPECT_EQ(std::string(" hey there "), *str->value); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 74 | } |
| 75 | |
| 76 | TEST_F(ResourceParserTest, ParseEscapedString) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 77 | std::string input = "<string name=\"foo\">\\?123</string>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 78 | ASSERT_TRUE(testParse(input)); |
| 79 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 80 | String* str = test::getValue<String>(&mTable, "string/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 81 | ASSERT_NE(nullptr, str); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 82 | EXPECT_EQ(std::string("?123"), *str->value); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 83 | } |
| 84 | |
Adam Lesinski | 9f22204 | 2015-11-04 13:51:45 -0800 | [diff] [blame] | 85 | TEST_F(ResourceParserTest, ParseFormattedString) { |
| 86 | std::string input = "<string name=\"foo\">%d %s</string>"; |
| 87 | ASSERT_FALSE(testParse(input)); |
| 88 | |
| 89 | input = "<string name=\"foo\">%1$d %2$s</string>"; |
| 90 | ASSERT_TRUE(testParse(input)); |
| 91 | } |
| 92 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 93 | TEST_F(ResourceParserTest, IgnoreXliffTags) { |
| 94 | std::string input = "<string name=\"foo\" \n" |
| 95 | " xmlns:xliff=\"urn:oasis:names:tc:xliff:document:1.2\">\n" |
| 96 | " There are <xliff:g id=\"count\">%1$d</xliff:g> apples</string>"; |
| 97 | ASSERT_TRUE(testParse(input)); |
| 98 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 99 | String* str = test::getValue<String>(&mTable, "string/foo"); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 100 | ASSERT_NE(nullptr, str); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 101 | EXPECT_EQ(StringPiece("There are %1$d apples"), StringPiece(*str->value)); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 102 | } |
| 103 | |
Adam Lesinski | dfa5e07 | 2015-05-12 21:42:59 -0700 | [diff] [blame] | 104 | TEST_F(ResourceParserTest, ParseNull) { |
| 105 | std::string input = "<integer name=\"foo\">@null</integer>"; |
| 106 | ASSERT_TRUE(testParse(input)); |
| 107 | |
| 108 | // The Android runtime treats a value of android::Res_value::TYPE_NULL as |
| 109 | // a non-existing value, and this causes problems in styles when trying to resolve |
| 110 | // an attribute. Null values must be encoded as android::Res_value::TYPE_REFERENCE |
| 111 | // with a data value of 0. |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 112 | BinaryPrimitive* integer = test::getValue<BinaryPrimitive>(&mTable, "integer/foo"); |
Adam Lesinski | dfa5e07 | 2015-05-12 21:42:59 -0700 | [diff] [blame] | 113 | ASSERT_NE(nullptr, integer); |
| 114 | EXPECT_EQ(uint16_t(android::Res_value::TYPE_REFERENCE), integer->value.dataType); |
| 115 | EXPECT_EQ(0u, integer->value.data); |
| 116 | } |
| 117 | |
| 118 | TEST_F(ResourceParserTest, ParseEmpty) { |
| 119 | std::string input = "<integer name=\"foo\">@empty</integer>"; |
| 120 | ASSERT_TRUE(testParse(input)); |
| 121 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 122 | BinaryPrimitive* integer = test::getValue<BinaryPrimitive>(&mTable, "integer/foo"); |
Adam Lesinski | dfa5e07 | 2015-05-12 21:42:59 -0700 | [diff] [blame] | 123 | ASSERT_NE(nullptr, integer); |
| 124 | EXPECT_EQ(uint16_t(android::Res_value::TYPE_NULL), integer->value.dataType); |
| 125 | EXPECT_EQ(uint32_t(android::Res_value::DATA_NULL_EMPTY), integer->value.data); |
| 126 | } |
| 127 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 128 | TEST_F(ResourceParserTest, ParseAttr) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 129 | std::string input = "<attr name=\"foo\" format=\"string\"/>\n" |
| 130 | "<attr name=\"bar\"/>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 131 | ASSERT_TRUE(testParse(input)); |
| 132 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 133 | Attribute* attr = test::getValue<Attribute>(&mTable, "attr/foo"); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 134 | ASSERT_NE(nullptr, attr); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 135 | EXPECT_EQ(uint32_t(android::ResTable_map::TYPE_STRING), attr->typeMask); |
| 136 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 137 | attr = test::getValue<Attribute>(&mTable, "attr/bar"); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 138 | ASSERT_NE(nullptr, attr); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 139 | EXPECT_EQ(uint32_t(android::ResTable_map::TYPE_ANY), attr->typeMask); |
| 140 | } |
| 141 | |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 142 | // Old AAPT allowed attributes to be defined under different configurations, but ultimately |
| 143 | // stored them with the default configuration. Check that we have the same behavior. |
| 144 | TEST_F(ResourceParserTest, ParseAttrAndDeclareStyleableUnderConfigButRecordAsNoConfig) { |
| 145 | const ConfigDescription watchConfig = test::parseConfigOrDie("watch"); |
| 146 | std::string input = R"EOF( |
| 147 | <attr name="foo" /> |
| 148 | <declare-styleable name="bar"> |
| 149 | <attr name="baz" /> |
| 150 | </declare-styleable>)EOF"; |
| 151 | ASSERT_TRUE(testParse(input, watchConfig)); |
| 152 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 153 | EXPECT_EQ(nullptr, test::getValueForConfig<Attribute>(&mTable, "attr/foo", watchConfig)); |
| 154 | EXPECT_EQ(nullptr, test::getValueForConfig<Attribute>(&mTable, "attr/baz", watchConfig)); |
| 155 | EXPECT_EQ(nullptr, test::getValueForConfig<Styleable>(&mTable, "styleable/bar", watchConfig)); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 156 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 157 | EXPECT_NE(nullptr, test::getValue<Attribute>(&mTable, "attr/foo")); |
| 158 | EXPECT_NE(nullptr, test::getValue<Attribute>(&mTable, "attr/baz")); |
| 159 | EXPECT_NE(nullptr, test::getValue<Styleable>(&mTable, "styleable/bar")); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 160 | } |
| 161 | |
Adam Lesinski | a587065 | 2015-11-20 15:32:30 -0800 | [diff] [blame] | 162 | TEST_F(ResourceParserTest, ParseAttrWithMinMax) { |
| 163 | std::string input = "<attr name=\"foo\" min=\"10\" max=\"23\" format=\"integer\"/>"; |
| 164 | ASSERT_TRUE(testParse(input)); |
| 165 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 166 | Attribute* attr = test::getValue<Attribute>(&mTable, "attr/foo"); |
Adam Lesinski | a587065 | 2015-11-20 15:32:30 -0800 | [diff] [blame] | 167 | ASSERT_NE(nullptr, attr); |
| 168 | EXPECT_EQ(uint32_t(android::ResTable_map::TYPE_INTEGER), attr->typeMask); |
| 169 | EXPECT_EQ(10, attr->minInt); |
| 170 | EXPECT_EQ(23, attr->maxInt); |
| 171 | } |
| 172 | |
| 173 | TEST_F(ResourceParserTest, FailParseAttrWithMinMaxButNotInteger) { |
| 174 | std::string input = "<attr name=\"foo\" min=\"10\" max=\"23\" format=\"string\"/>"; |
| 175 | ASSERT_FALSE(testParse(input)); |
| 176 | } |
| 177 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 178 | TEST_F(ResourceParserTest, ParseUseAndDeclOfAttr) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 179 | std::string input = "<declare-styleable name=\"Styleable\">\n" |
| 180 | " <attr name=\"foo\" />\n" |
| 181 | "</declare-styleable>\n" |
| 182 | "<attr name=\"foo\" format=\"string\"/>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 183 | ASSERT_TRUE(testParse(input)); |
| 184 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 185 | Attribute* attr = test::getValue<Attribute>(&mTable, "attr/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 186 | ASSERT_NE(nullptr, attr); |
| 187 | EXPECT_EQ(uint32_t(android::ResTable_map::TYPE_STRING), attr->typeMask); |
| 188 | } |
| 189 | |
| 190 | TEST_F(ResourceParserTest, ParseDoubleUseOfAttr) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 191 | std::string input = "<declare-styleable name=\"Theme\">" |
| 192 | " <attr name=\"foo\" />\n" |
| 193 | "</declare-styleable>\n" |
| 194 | "<declare-styleable name=\"Window\">\n" |
| 195 | " <attr name=\"foo\" format=\"boolean\"/>\n" |
| 196 | "</declare-styleable>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 197 | ASSERT_TRUE(testParse(input)); |
| 198 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 199 | Attribute* attr = test::getValue<Attribute>(&mTable, "attr/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 200 | ASSERT_NE(nullptr, attr); |
| 201 | EXPECT_EQ(uint32_t(android::ResTable_map::TYPE_BOOLEAN), attr->typeMask); |
| 202 | } |
| 203 | |
| 204 | TEST_F(ResourceParserTest, ParseEnumAttr) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 205 | std::string input = "<attr name=\"foo\">\n" |
| 206 | " <enum name=\"bar\" value=\"0\"/>\n" |
| 207 | " <enum name=\"bat\" value=\"1\"/>\n" |
| 208 | " <enum name=\"baz\" value=\"2\"/>\n" |
| 209 | "</attr>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 210 | ASSERT_TRUE(testParse(input)); |
| 211 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 212 | Attribute* enumAttr = test::getValue<Attribute>(&mTable, "attr/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 213 | ASSERT_NE(enumAttr, nullptr); |
| 214 | EXPECT_EQ(enumAttr->typeMask, android::ResTable_map::TYPE_ENUM); |
| 215 | ASSERT_EQ(enumAttr->symbols.size(), 3u); |
| 216 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 217 | AAPT_ASSERT_TRUE(enumAttr->symbols[0].symbol.name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 218 | EXPECT_EQ(enumAttr->symbols[0].symbol.name.value().entry, "bar"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 219 | EXPECT_EQ(enumAttr->symbols[0].value, 0u); |
| 220 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 221 | AAPT_ASSERT_TRUE(enumAttr->symbols[1].symbol.name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 222 | EXPECT_EQ(enumAttr->symbols[1].symbol.name.value().entry, "bat"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 223 | EXPECT_EQ(enumAttr->symbols[1].value, 1u); |
| 224 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 225 | AAPT_ASSERT_TRUE(enumAttr->symbols[2].symbol.name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 226 | EXPECT_EQ(enumAttr->symbols[2].symbol.name.value().entry, "baz"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 227 | EXPECT_EQ(enumAttr->symbols[2].value, 2u); |
| 228 | } |
| 229 | |
| 230 | TEST_F(ResourceParserTest, ParseFlagAttr) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 231 | std::string input = "<attr name=\"foo\">\n" |
| 232 | " <flag name=\"bar\" value=\"0\"/>\n" |
| 233 | " <flag name=\"bat\" value=\"1\"/>\n" |
| 234 | " <flag name=\"baz\" value=\"2\"/>\n" |
| 235 | "</attr>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 236 | ASSERT_TRUE(testParse(input)); |
| 237 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 238 | Attribute* flagAttr = test::getValue<Attribute>(&mTable, "attr/foo"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 239 | ASSERT_NE(nullptr, flagAttr); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 240 | EXPECT_EQ(flagAttr->typeMask, android::ResTable_map::TYPE_FLAGS); |
| 241 | ASSERT_EQ(flagAttr->symbols.size(), 3u); |
| 242 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 243 | AAPT_ASSERT_TRUE(flagAttr->symbols[0].symbol.name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 244 | EXPECT_EQ(flagAttr->symbols[0].symbol.name.value().entry, "bar"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 245 | EXPECT_EQ(flagAttr->symbols[0].value, 0u); |
| 246 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 247 | AAPT_ASSERT_TRUE(flagAttr->symbols[1].symbol.name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 248 | EXPECT_EQ(flagAttr->symbols[1].symbol.name.value().entry, "bat"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 249 | EXPECT_EQ(flagAttr->symbols[1].value, 1u); |
| 250 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 251 | AAPT_ASSERT_TRUE(flagAttr->symbols[2].symbol.name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 252 | EXPECT_EQ(flagAttr->symbols[2].symbol.name.value().entry, "baz"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 253 | EXPECT_EQ(flagAttr->symbols[2].value, 2u); |
| 254 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 255 | std::unique_ptr<BinaryPrimitive> flagValue = ResourceUtils::tryParseFlagSymbol(flagAttr, |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 256 | "baz|bat"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 257 | ASSERT_NE(nullptr, flagValue); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 258 | EXPECT_EQ(flagValue->value.data, 1u | 2u); |
| 259 | } |
| 260 | |
| 261 | TEST_F(ResourceParserTest, FailToParseEnumAttrWithNonUniqueKeys) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 262 | std::string input = "<attr name=\"foo\">\n" |
| 263 | " <enum name=\"bar\" value=\"0\"/>\n" |
| 264 | " <enum name=\"bat\" value=\"1\"/>\n" |
| 265 | " <enum name=\"bat\" value=\"2\"/>\n" |
| 266 | "</attr>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 267 | ASSERT_FALSE(testParse(input)); |
| 268 | } |
| 269 | |
| 270 | TEST_F(ResourceParserTest, ParseStyle) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 271 | std::string input = "<style name=\"foo\" parent=\"@style/fu\">\n" |
| 272 | " <item name=\"bar\">#ffffffff</item>\n" |
| 273 | " <item name=\"bat\">@string/hey</item>\n" |
| 274 | " <item name=\"baz\"><b>hey</b></item>\n" |
| 275 | "</style>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 276 | ASSERT_TRUE(testParse(input)); |
| 277 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 278 | Style* style = test::getValue<Style>(&mTable, "style/foo"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 279 | ASSERT_NE(nullptr, style); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 280 | AAPT_ASSERT_TRUE(style->parent); |
| 281 | AAPT_ASSERT_TRUE(style->parent.value().name); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 282 | EXPECT_EQ(test::parseNameOrDie("style/fu"), style->parent.value().name.value()); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 283 | ASSERT_EQ(3u, style->entries.size()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 284 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 285 | AAPT_ASSERT_TRUE(style->entries[0].key.name); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 286 | EXPECT_EQ(test::parseNameOrDie("attr/bar"), style->entries[0].key.name.value()); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 287 | |
| 288 | AAPT_ASSERT_TRUE(style->entries[1].key.name); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 289 | EXPECT_EQ(test::parseNameOrDie("attr/bat"), style->entries[1].key.name.value()); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 290 | |
| 291 | AAPT_ASSERT_TRUE(style->entries[2].key.name); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 292 | EXPECT_EQ(test::parseNameOrDie("attr/baz"), style->entries[2].key.name.value()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 293 | } |
| 294 | |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 295 | TEST_F(ResourceParserTest, ParseStyleWithShorthandParent) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 296 | std::string input = "<style name=\"foo\" parent=\"com.app:Theme\"/>"; |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 297 | ASSERT_TRUE(testParse(input)); |
| 298 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 299 | Style* style = test::getValue<Style>(&mTable, "style/foo"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 300 | ASSERT_NE(nullptr, style); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 301 | AAPT_ASSERT_TRUE(style->parent); |
| 302 | AAPT_ASSERT_TRUE(style->parent.value().name); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 303 | EXPECT_EQ(test::parseNameOrDie("com.app:style/Theme"), style->parent.value().name.value()); |
Adam Lesinski | 769de98 | 2015-04-10 19:43:55 -0700 | [diff] [blame] | 304 | } |
| 305 | |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 306 | TEST_F(ResourceParserTest, ParseStyleWithPackageAliasedParent) { |
| 307 | std::string input = "<style xmlns:app=\"http://schemas.android.com/apk/res/android\"\n" |
| 308 | " name=\"foo\" parent=\"app:Theme\"/>"; |
| 309 | ASSERT_TRUE(testParse(input)); |
| 310 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 311 | Style* style = test::getValue<Style>(&mTable, "style/foo"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 312 | ASSERT_NE(nullptr, style); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 313 | AAPT_ASSERT_TRUE(style->parent); |
| 314 | AAPT_ASSERT_TRUE(style->parent.value().name); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 315 | EXPECT_EQ(test::parseNameOrDie("android:style/Theme"), style->parent.value().name.value()); |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 316 | } |
| 317 | |
| 318 | TEST_F(ResourceParserTest, ParseStyleWithPackageAliasedItems) { |
| 319 | std::string input = |
| 320 | "<style xmlns:app=\"http://schemas.android.com/apk/res/android\" name=\"foo\">\n" |
| 321 | " <item name=\"app:bar\">0</item>\n" |
| 322 | "</style>"; |
| 323 | ASSERT_TRUE(testParse(input)); |
| 324 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 325 | Style* style = test::getValue<Style>(&mTable, "style/foo"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 326 | ASSERT_NE(nullptr, style); |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 327 | ASSERT_EQ(1u, style->entries.size()); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 328 | EXPECT_EQ(test::parseNameOrDie("android:attr/bar"), style->entries[0].key.name.value()); |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 329 | } |
| 330 | |
Adam Lesinski | bdaa092 | 2015-05-08 20:16:23 -0700 | [diff] [blame] | 331 | TEST_F(ResourceParserTest, ParseStyleWithInferredParent) { |
| 332 | std::string input = "<style name=\"foo.bar\"/>"; |
| 333 | ASSERT_TRUE(testParse(input)); |
| 334 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 335 | Style* style = test::getValue<Style>(&mTable, "style/foo.bar"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 336 | ASSERT_NE(nullptr, style); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 337 | AAPT_ASSERT_TRUE(style->parent); |
| 338 | AAPT_ASSERT_TRUE(style->parent.value().name); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 339 | EXPECT_EQ(style->parent.value().name.value(), test::parseNameOrDie("style/foo")); |
Adam Lesinski | bdaa092 | 2015-05-08 20:16:23 -0700 | [diff] [blame] | 340 | EXPECT_TRUE(style->parentInferred); |
| 341 | } |
| 342 | |
| 343 | TEST_F(ResourceParserTest, ParseStyleWithInferredParentOverridenByEmptyParentAttribute) { |
| 344 | std::string input = "<style name=\"foo.bar\" parent=\"\"/>"; |
| 345 | ASSERT_TRUE(testParse(input)); |
| 346 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 347 | Style* style = test::getValue<Style>(&mTable, "style/foo.bar"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 348 | ASSERT_NE(nullptr, style); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 349 | AAPT_EXPECT_FALSE(style->parent); |
Adam Lesinski | bdaa092 | 2015-05-08 20:16:23 -0700 | [diff] [blame] | 350 | EXPECT_FALSE(style->parentInferred); |
| 351 | } |
| 352 | |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 353 | TEST_F(ResourceParserTest, ParseStyleWithPrivateParentReference) { |
| 354 | std::string input = R"EOF(<style name="foo" parent="*android:style/bar" />)EOF"; |
| 355 | ASSERT_TRUE(testParse(input)); |
| 356 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 357 | Style* style = test::getValue<Style>(&mTable, "style/foo"); |
Adam Lesinski | 24b8ff0 | 2015-12-16 14:01:57 -0800 | [diff] [blame] | 358 | ASSERT_NE(nullptr, style); |
| 359 | AAPT_ASSERT_TRUE(style->parent); |
| 360 | EXPECT_TRUE(style->parent.value().privateReference); |
| 361 | } |
| 362 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 363 | TEST_F(ResourceParserTest, ParseAutoGeneratedIdReference) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 364 | std::string input = "<string name=\"foo\">@+id/bar</string>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 365 | ASSERT_TRUE(testParse(input)); |
| 366 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 367 | Id* id = test::getValue<Id>(&mTable, "id/bar"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 368 | ASSERT_NE(id, nullptr); |
| 369 | } |
| 370 | |
| 371 | TEST_F(ResourceParserTest, ParseAttributesDeclareStyleable) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 372 | std::string input = "<declare-styleable name=\"foo\">\n" |
| 373 | " <attr name=\"bar\" />\n" |
| 374 | " <attr name=\"bat\" format=\"string|reference\"/>\n" |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 375 | " <attr name=\"baz\">\n" |
| 376 | " <enum name=\"foo\" value=\"1\"/>\n" |
| 377 | " </attr>\n" |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 378 | "</declare-styleable>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 379 | ASSERT_TRUE(testParse(input)); |
| 380 | |
Adam Lesinski | 9f22204 | 2015-11-04 13:51:45 -0800 | [diff] [blame] | 381 | Maybe<ResourceTable::SearchResult> result = |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 382 | mTable.findResource(test::parseNameOrDie("styleable/foo")); |
Adam Lesinski | 9f22204 | 2015-11-04 13:51:45 -0800 | [diff] [blame] | 383 | AAPT_ASSERT_TRUE(result); |
| 384 | EXPECT_EQ(SymbolState::kPublic, result.value().entry->symbolStatus.state); |
| 385 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 386 | Attribute* attr = test::getValue<Attribute>(&mTable, "attr/bar"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 387 | ASSERT_NE(attr, nullptr); |
| 388 | EXPECT_TRUE(attr->isWeak()); |
| 389 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 390 | attr = test::getValue<Attribute>(&mTable, "attr/bat"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 391 | ASSERT_NE(attr, nullptr); |
| 392 | EXPECT_TRUE(attr->isWeak()); |
| 393 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 394 | attr = test::getValue<Attribute>(&mTable, "attr/baz"); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 395 | ASSERT_NE(attr, nullptr); |
| 396 | EXPECT_TRUE(attr->isWeak()); |
| 397 | EXPECT_EQ(1u, attr->symbols.size()); |
| 398 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 399 | EXPECT_NE(nullptr, test::getValue<Id>(&mTable, "id/foo")); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 400 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 401 | Styleable* styleable = test::getValue<Styleable>(&mTable, "styleable/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 402 | ASSERT_NE(styleable, nullptr); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 403 | ASSERT_EQ(3u, styleable->entries.size()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 404 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 405 | EXPECT_EQ(test::parseNameOrDie("attr/bar"), styleable->entries[0].name.value()); |
| 406 | EXPECT_EQ(test::parseNameOrDie("attr/bat"), styleable->entries[1].name.value()); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 407 | } |
| 408 | |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 409 | TEST_F(ResourceParserTest, ParsePrivateAttributesDeclareStyleable) { |
| 410 | std::string input = "<declare-styleable name=\"foo\" xmlns:privAndroid=\"http://schemas.android.com/apk/prv/res/android\">\n" |
| 411 | " <attr name=\"*android:bar\" />\n" |
| 412 | " <attr name=\"privAndroid:bat\" />\n" |
| 413 | "</declare-styleable>"; |
| 414 | ASSERT_TRUE(testParse(input)); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 415 | Styleable* styleable = test::getValue<Styleable>(&mTable, "styleable/foo"); |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 416 | ASSERT_NE(nullptr, styleable); |
| 417 | ASSERT_EQ(2u, styleable->entries.size()); |
| 418 | |
| 419 | EXPECT_TRUE(styleable->entries[0].privateReference); |
| 420 | AAPT_ASSERT_TRUE(styleable->entries[0].name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 421 | EXPECT_EQ(std::string("android"), styleable->entries[0].name.value().package); |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 422 | |
| 423 | EXPECT_TRUE(styleable->entries[1].privateReference); |
| 424 | AAPT_ASSERT_TRUE(styleable->entries[1].name); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 425 | EXPECT_EQ(std::string("android"), styleable->entries[1].name.value().package); |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 426 | } |
| 427 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 428 | TEST_F(ResourceParserTest, ParseArray) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 429 | std::string input = "<array name=\"foo\">\n" |
| 430 | " <item>@string/ref</item>\n" |
| 431 | " <item>hey</item>\n" |
| 432 | " <item>23</item>\n" |
| 433 | "</array>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 434 | ASSERT_TRUE(testParse(input)); |
| 435 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 436 | Array* array = test::getValue<Array>(&mTable, "array/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 437 | ASSERT_NE(array, nullptr); |
| 438 | ASSERT_EQ(3u, array->items.size()); |
| 439 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 440 | EXPECT_NE(nullptr, valueCast<Reference>(array->items[0].get())); |
| 441 | EXPECT_NE(nullptr, valueCast<String>(array->items[1].get())); |
| 442 | EXPECT_NE(nullptr, valueCast<BinaryPrimitive>(array->items[2].get())); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 443 | } |
| 444 | |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 445 | TEST_F(ResourceParserTest, ParseStringArray) { |
| 446 | std::string input = "<string-array name=\"foo\">\n" |
| 447 | " <item>\"Werk\"</item>\n" |
| 448 | "</string-array>\n"; |
| 449 | ASSERT_TRUE(testParse(input)); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 450 | EXPECT_NE(nullptr, test::getValue<Array>(&mTable, "array/foo")); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 451 | } |
| 452 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 453 | TEST_F(ResourceParserTest, ParsePlural) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 454 | std::string input = "<plurals name=\"foo\">\n" |
| 455 | " <item quantity=\"other\">apples</item>\n" |
| 456 | " <item quantity=\"one\">apple</item>\n" |
| 457 | "</plurals>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 458 | ASSERT_TRUE(testParse(input)); |
| 459 | } |
| 460 | |
| 461 | TEST_F(ResourceParserTest, ParseCommentsWithResource) { |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 462 | std::string input = "<!--This is a comment-->\n" |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 463 | "<string name=\"foo\">Hi</string>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 464 | ASSERT_TRUE(testParse(input)); |
| 465 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 466 | String* value = test::getValue<String>(&mTable, "string/foo"); |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 467 | ASSERT_NE(nullptr, value); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 468 | EXPECT_EQ(value->getComment(), "This is a comment"); |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 469 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 470 | |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 471 | TEST_F(ResourceParserTest, DoNotCombineMultipleComments) { |
| 472 | std::string input = "<!--One-->\n" |
| 473 | "<!--Two-->\n" |
| 474 | "<string name=\"foo\">Hi</string>"; |
| 475 | |
| 476 | ASSERT_TRUE(testParse(input)); |
| 477 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 478 | String* value = test::getValue<String>(&mTable, "string/foo"); |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 479 | ASSERT_NE(nullptr, value); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 480 | EXPECT_EQ(value->getComment(), "Two"); |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 481 | } |
| 482 | |
| 483 | TEST_F(ResourceParserTest, IgnoreCommentBeforeEndTag) { |
| 484 | std::string input = "<!--One-->\n" |
| 485 | "<string name=\"foo\">\n" |
| 486 | " Hi\n" |
| 487 | "<!--Two-->\n" |
| 488 | "</string>"; |
| 489 | |
| 490 | ASSERT_TRUE(testParse(input)); |
| 491 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 492 | String* value = test::getValue<String>(&mTable, "string/foo"); |
Adam Lesinski | e78fd61 | 2015-10-22 12:48:43 -0700 | [diff] [blame] | 493 | ASSERT_NE(nullptr, value); |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 494 | EXPECT_EQ(value->getComment(), "One"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 495 | } |
| 496 | |
Adam Lesinski | ca5638f | 2015-10-21 14:42:43 -0700 | [diff] [blame] | 497 | TEST_F(ResourceParserTest, ParseNestedComments) { |
| 498 | // We only care about declare-styleable and enum/flag attributes because comments |
| 499 | // from those end up in R.java |
| 500 | std::string input = R"EOF( |
| 501 | <declare-styleable name="foo"> |
| 502 | <!-- The name of the bar --> |
| 503 | <attr name="barName" format="string|reference" /> |
| 504 | </declare-styleable> |
| 505 | |
| 506 | <attr name="foo"> |
| 507 | <!-- The very first --> |
| 508 | <enum name="one" value="1" /> |
| 509 | </attr>)EOF"; |
| 510 | ASSERT_TRUE(testParse(input)); |
| 511 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 512 | Styleable* styleable = test::getValue<Styleable>(&mTable, "styleable/foo"); |
Adam Lesinski | ca5638f | 2015-10-21 14:42:43 -0700 | [diff] [blame] | 513 | ASSERT_NE(nullptr, styleable); |
| 514 | ASSERT_EQ(1u, styleable->entries.size()); |
| 515 | |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 516 | EXPECT_EQ(StringPiece("The name of the bar"), styleable->entries.front().getComment()); |
Adam Lesinski | ca5638f | 2015-10-21 14:42:43 -0700 | [diff] [blame] | 517 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 518 | Attribute* attr = test::getValue<Attribute>(&mTable, "attr/foo"); |
Adam Lesinski | ca5638f | 2015-10-21 14:42:43 -0700 | [diff] [blame] | 519 | ASSERT_NE(nullptr, attr); |
| 520 | ASSERT_EQ(1u, attr->symbols.size()); |
| 521 | |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 522 | EXPECT_EQ(StringPiece("The very first"), attr->symbols.front().symbol.getComment()); |
Adam Lesinski | ca5638f | 2015-10-21 14:42:43 -0700 | [diff] [blame] | 523 | } |
| 524 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 525 | /* |
| 526 | * Declaring an ID as public should not require a separate definition |
| 527 | * (as an ID has no value). |
| 528 | */ |
| 529 | TEST_F(ResourceParserTest, ParsePublicIdAsDefinition) { |
Adam Lesinski | 24aad16 | 2015-04-24 19:19:30 -0700 | [diff] [blame] | 530 | std::string input = "<public type=\"id\" name=\"foo\"/>"; |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 531 | ASSERT_TRUE(testParse(input)); |
| 532 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 533 | Id* id = test::getValue<Id>(&mTable, "id/foo"); |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 534 | ASSERT_NE(nullptr, id); |
| 535 | } |
| 536 | |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 537 | TEST_F(ResourceParserTest, KeepAllProducts) { |
Adam Lesinski | 7751afc | 2016-01-06 15:45:28 -0800 | [diff] [blame] | 538 | std::string input = R"EOF( |
| 539 | <string name="foo" product="phone">hi</string> |
| 540 | <string name="foo" product="no-sdcard">ho</string> |
| 541 | <string name="bar" product="">wee</string> |
| 542 | <string name="baz">woo</string> |
| 543 | <string name="bit" product="phablet">hoot</string> |
| 544 | <string name="bot" product="default">yes</string> |
| 545 | )EOF"; |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 546 | ASSERT_TRUE(testParse(input)); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 547 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 548 | EXPECT_NE(nullptr, test::getValueForConfigAndProduct<String>(&mTable, "string/foo", |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 549 | ConfigDescription::defaultConfig(), |
| 550 | "phone")); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 551 | EXPECT_NE(nullptr, test::getValueForConfigAndProduct<String>(&mTable, "string/foo", |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 552 | ConfigDescription::defaultConfig(), |
| 553 | "no-sdcard")); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 554 | EXPECT_NE(nullptr, test::getValueForConfigAndProduct<String>(&mTable, "string/bar", |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 555 | ConfigDescription::defaultConfig(), |
| 556 | "")); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 557 | EXPECT_NE(nullptr, test::getValueForConfigAndProduct<String>(&mTable, "string/baz", |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 558 | ConfigDescription::defaultConfig(), |
| 559 | "")); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 560 | EXPECT_NE(nullptr, test::getValueForConfigAndProduct<String>(&mTable, "string/bit", |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 561 | ConfigDescription::defaultConfig(), |
| 562 | "phablet")); |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 563 | EXPECT_NE(nullptr, test::getValueForConfigAndProduct<String>(&mTable, "string/bot", |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 564 | ConfigDescription::defaultConfig(), |
| 565 | "default")); |
Adam Lesinski | 9ba47d8 | 2015-10-13 11:37:10 -0700 | [diff] [blame] | 566 | } |
| 567 | |
Adam Lesinski | 27afb9e | 2015-11-06 18:25:04 -0800 | [diff] [blame] | 568 | TEST_F(ResourceParserTest, AutoIncrementIdsInPublicGroup) { |
| 569 | std::string input = R"EOF( |
| 570 | <public-group type="attr" first-id="0x01010040"> |
| 571 | <public name="foo" /> |
| 572 | <public name="bar" /> |
| 573 | </public-group>)EOF"; |
| 574 | ASSERT_TRUE(testParse(input)); |
| 575 | |
| 576 | Maybe<ResourceTable::SearchResult> result = mTable.findResource( |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 577 | test::parseNameOrDie("attr/foo")); |
Adam Lesinski | 27afb9e | 2015-11-06 18:25:04 -0800 | [diff] [blame] | 578 | AAPT_ASSERT_TRUE(result); |
| 579 | |
| 580 | AAPT_ASSERT_TRUE(result.value().package->id); |
| 581 | AAPT_ASSERT_TRUE(result.value().type->id); |
| 582 | AAPT_ASSERT_TRUE(result.value().entry->id); |
| 583 | ResourceId actualId(result.value().package->id.value(), |
| 584 | result.value().type->id.value(), |
| 585 | result.value().entry->id.value()); |
| 586 | EXPECT_EQ(ResourceId(0x01010040), actualId); |
| 587 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 588 | result = mTable.findResource(test::parseNameOrDie("attr/bar")); |
Adam Lesinski | 27afb9e | 2015-11-06 18:25:04 -0800 | [diff] [blame] | 589 | AAPT_ASSERT_TRUE(result); |
| 590 | |
| 591 | AAPT_ASSERT_TRUE(result.value().package->id); |
| 592 | AAPT_ASSERT_TRUE(result.value().type->id); |
| 593 | AAPT_ASSERT_TRUE(result.value().entry->id); |
| 594 | actualId = ResourceId(result.value().package->id.value(), |
| 595 | result.value().type->id.value(), |
| 596 | result.value().entry->id.value()); |
| 597 | EXPECT_EQ(ResourceId(0x01010041), actualId); |
| 598 | } |
| 599 | |
Adam Lesinski | fa10505 | 2015-11-07 13:34:39 -0800 | [diff] [blame] | 600 | TEST_F(ResourceParserTest, ExternalTypesShouldOnlyBeReferences) { |
| 601 | std::string input = R"EOF(<item type="layout" name="foo">@layout/bar</item>)EOF"; |
| 602 | ASSERT_TRUE(testParse(input)); |
| 603 | |
| 604 | input = R"EOF(<item type="layout" name="bar">"this is a string"</item>)EOF"; |
| 605 | ASSERT_FALSE(testParse(input)); |
| 606 | } |
| 607 | |
Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 608 | TEST_F(ResourceParserTest, AddResourcesElementShouldAddEntryWithUndefinedSymbol) { |
| 609 | std::string input = R"EOF(<add-resource name="bar" type="string" />)EOF"; |
| 610 | ASSERT_TRUE(testParse(input)); |
| 611 | |
| 612 | Maybe<ResourceTable::SearchResult> result = mTable.findResource( |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 613 | test::parseNameOrDie("string/bar")); |
Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 614 | AAPT_ASSERT_TRUE(result); |
| 615 | const ResourceEntry* entry = result.value().entry; |
| 616 | ASSERT_NE(nullptr, entry); |
| 617 | EXPECT_EQ(SymbolState::kUndefined, entry->symbolStatus.state); |
| 618 | } |
| 619 | |
Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 620 | TEST_F(ResourceParserTest, ParseItemElementWithFormat) { |
| 621 | std::string input = R"EOF(<item name="foo" type="integer" format="float">0.3</item>)EOF"; |
| 622 | ASSERT_TRUE(testParse(input)); |
| 623 | |
Adam Lesinski | 58a20a6 | 2016-07-25 17:56:58 -0700 | [diff] [blame] | 624 | BinaryPrimitive* val = test::getValue<BinaryPrimitive>(&mTable, "integer/foo"); |
Adam Lesinski | 7ff3ee1 | 2015-12-14 16:08:50 -0800 | [diff] [blame] | 625 | ASSERT_NE(nullptr, val); |
| 626 | |
| 627 | EXPECT_EQ(uint32_t(android::Res_value::TYPE_FLOAT), val->value.dataType); |
| 628 | } |
| 629 | |
Adam Lesinski | 6f6ceb7 | 2014-11-14 14:48:12 -0800 | [diff] [blame] | 630 | } // namespace aapt |