Improved usage of stderr for logging.
Dumpstate have some macros that write logs to both ALOG and stderr,
which is useful when the latter is redirected to a file.
But prior to this change, only the log statements from dumpstate.cpp
were using it, and utils.cpp was logging to stderr directly.
This change not only uses MYLOGE for all error messages, but also closes
stderr at the very end (so it doesn't miss statements like the
parameters sent to send_broadcast) and uses MYLOGD for the overall progress.
BUG: 27437378
Change-Id: I373a523e20c98d8f445822103784fa9900c6c684
diff --git a/cmds/dumpstate/dumpstate.cpp b/cmds/dumpstate/dumpstate.cpp
index f302529..b52a829 100644
--- a/cmds/dumpstate/dumpstate.cpp
+++ b/cmds/dumpstate/dumpstate.cpp
@@ -1273,7 +1273,6 @@
/* close output if needed */
if (is_redirecting) {
fclose(stdout);
- fclose(stderr);
}
/* rename or zip the (now complete) .tmp file to its final location */
@@ -1382,5 +1381,9 @@
MYLOGD("Final progress: %d/%d (originally %d)\n", progress, weight_total, WEIGHT_TOTAL);
MYLOGI("done\n");
+ if (is_redirecting) {
+ fclose(stderr);
+ }
+
return 0;
}