commit 617cf15817dcdd6eed2668f87ff5352c5a5db46b
author TreeHugger Robot <treehugger-gerrit@google.com> Thu Apr 18 04:11:23 2019 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Thu Apr 18 04:11:23 2019 +0000
tree ced78385960ebf958475220604dfcddbf243c4a2
parent 6c7d5c27888b50a309ae2c3c2484d0d88b7323c8
parent b0022cc49371bfc5d9bd10fb8e60c29b1ff4aef6

Merge "blast: transaction ordering" into qt-dev

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 42ea363..ad58717 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -3620,7 +3620,7 @@
     }
 
     // If the state doesn't require a traversal and there are callbacks, send them now
-    if (!(clientStateFlags & eTraversalNeeded)) {
+    if (!(clientStateFlags & eTraversalNeeded) && !listenerCallbacks.empty()) {
         mTransactionCompletedThread.sendCallbacks();
     }
     transactionFlags |= clientStateFlags;

services/surfaceflinger/TransactionCompletedThread.cpp

diff --git a/services/surfaceflinger/TransactionCompletedThread.cpp b/services/surfaceflinger/TransactionCompletedThread.cpp
index 34df606..b1bf4e2 100644
--- a/services/surfaceflinger/TransactionCompletedThread.cpp
+++ b/services/surfaceflinger/TransactionCompletedThread.cpp
@@ -141,12 +141,12 @@
             } else {
                 ALOGW("there are more latched callbacks than there were registered callbacks");
             }
+            if (listener->second.size() == 0) {
+                mPendingTransactions.erase(listener);
+            }
         } else {
             ALOGW("cannot find listener in mPendingTransactions");
         }
-        if (listener->second.size() == 0) {
-            mPendingTransactions.erase(listener);
-        }
 
         status_t err = addCallbackHandle(handle);
         if (err != NO_ERROR) {