commit 6d758fc418b5cde2229980cf84cfa0ac772777f9
author Greg Kaiser <gkaiser@google.com> Tue Mar 26 08:55:32 2019 -0700
committer Greg Kaiser <gkaiser@google.com> Tue Mar 26 09:28:23 2019 -0700
tree a5ab1ac83239c2f4a124cf92dd5b2e30f02629b6
parent 8042c37f15940479d9d89a97646555a01161a334

installd: Avoid extra std::string copy

The method is_valid_package_name() takes a const std::string
reference, so it's inefficient to pass a std::string::c_str().

Test: TreeHugger
Change-Id: Ic8b33ce8b6c664f960b5c84f688821e9f7eddf03

cmds/installd/InstalldNativeService.cpp

diff --git a/cmds/installd/InstalldNativeService.cpp b/cmds/installd/InstalldNativeService.cpp
index a51946d..ae4ea78 100644
--- a/cmds/installd/InstalldNativeService.cpp
+++ b/cmds/installd/InstalldNativeService.cpp
@@ -180,7 +180,7 @@
 }
 
 binder::Status checkArgumentPackageName(const std::string& packageName) {
-    if (is_valid_package_name(packageName.c_str())) {
+    if (is_valid_package_name(packageName)) {
         return ok();
     } else {
         return exception(binder::Status::EX_ILLEGAL_ARGUMENT,