commit 73e8b9e52411785189a35640e3ccb18574e38263
author Jamie Gennis <jgennis@google.com> Sat Jan 15 13:05:24 2011 -0800
committer Jamie Gennis <jgennis@google.com> Sat Jan 15 17:00:06 2011 -0800
tree 6b456bf4d4bc24ebd2db8886a7431f8d8020083a
parent bcb3e57eefeb5d043e59985ce5f61f8dcecf3da4

Compare GraphicBuffers using handles.

This change fixes a bug in SurfaceTextureClient where GraphicBuffers
were being compared using pointer comparison rather than handles.

Change-Id: Ib8989af94be32d4efd86e020a732f5143088a863

libs/gui/SurfaceTextureClient.cpp

diff --git a/libs/gui/SurfaceTextureClient.cpp b/libs/gui/SurfaceTextureClient.cpp
index 24cee24..0ed8be5 100644
--- a/libs/gui/SurfaceTextureClient.cpp
+++ b/libs/gui/SurfaceTextureClient.cpp
@@ -111,7 +111,7 @@
     LOGV("SurfaceTextureClient::cancelBuffer");
     Mutex::Autolock lock(mMutex);
     for (int i = 0; i < NUM_BUFFER_SLOTS; i++) {
-        if (mSlots[i].get() == buffer) {
+        if (mSlots[i]->handle == buffer->handle) {
             mSurfaceTexture->cancelBuffer(i);
             return OK;
         }
@@ -129,7 +129,7 @@
     LOGV("SurfaceTextureClient::queueBuffer");
     Mutex::Autolock lock(mMutex);
     for (int i = 0; i < NUM_BUFFER_SLOTS; i++) {
-        if (mSlots[i].get() == GraphicBuffer::getSelf(buffer)) {
+        if (mSlots[i]->handle == buffer->handle) {
             return mSurfaceTexture->queueBuffer(i);
         }
     }