commit 759fdb2ef735422d6b8c65e168fa9d1c24562a86
author Mathias Agopian <mathias@google.com> Thu Jul 02 17:33:40 2009 -0700
committer Mathias Agopian <mathias@google.com> Thu Jul 02 18:45:29 2009 -0700
tree 043f7f5a9288a37b0e888ebb2d537930c154a149
parent 84d1f7a09827fe195dd08b647b8c5092d03516f7

free gralloc buffers as soon as possible (when a surface is not visible any longer), client who have the buffers still mapped won't crash, btu may see garbage data

libs/surfaceflinger/Layer.cpp

diff --git a/libs/surfaceflinger/Layer.cpp b/libs/surfaceflinger/Layer.cpp
index c40fec1..9916158 100644
--- a/libs/surfaceflinger/Layer.cpp
+++ b/libs/surfaceflinger/Layer.cpp
@@ -76,7 +76,9 @@
             eglDestroyImageKHR(dpy, mTextures[i].image);
             mTextures[i].image = EGL_NO_IMAGE_KHR;
         }
+        mBuffers[i].free();
     }
+    mSurface.clear();
 }
 
 void Layer::initStates(uint32_t w, uint32_t h, uint32_t flags)
@@ -95,7 +97,6 @@
 status_t Layer::ditch()
 {
     // the layer is not on screen anymore. free as much resources as possible
-    mSurface.clear();
     destroy();
     return NO_ERROR;
 }