commit 788bdeae7858be59192f6a5a2a841170dc1325f7
author Jeff Sharkey <jsharkey@android.com> Thu Dec 15 21:59:08 2016 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Dec 15 21:59:08 2016 +0000
tree b15b1fc1e8a1640bbe020d87ed995db3fb8e8f80
parent 55e4f91258d8d42da3c7a13c295011f63c0aabdd
parent 2e6dc9baaaf5d50b42ce36435e13c2559808b837

Merge "Handle invalid shared GIDs."

cmds/installd/InstalldNativeService.cpp

diff --git a/cmds/installd/InstalldNativeService.cpp b/cmds/installd/InstalldNativeService.cpp
index bee947f..75e5668 100644
--- a/cmds/installd/InstalldNativeService.cpp
+++ b/cmds/installd/InstalldNativeService.cpp
@@ -322,8 +322,8 @@
             const std::string ref_profile_path = create_data_ref_profile_package_path(pkgname);
             // dex2oat/profman runs under the shared app gid and it needs to read/write reference
             // profiles.
-            appid_t shared_app_gid = multiuser_get_shared_app_gid(uid);
-            if (fs_prepare_dir_strict(
+            int shared_app_gid = multiuser_get_shared_app_gid(uid);
+            if ((shared_app_gid != -1) && fs_prepare_dir_strict(
                     ref_profile_path.c_str(), 0700, shared_app_gid, shared_app_gid) != 0) {
                 return error("Failed to prepare " + ref_profile_path);
             }