commit 7e453a51a5436c6c8c49c1e37cea5077bce09405
author Glenn Kasten <gkasten@google.com> Tue Feb 01 11:32:29 2011 -0800
committer Glenn Kasten <gkasten@google.com> Wed Feb 23 17:49:59 2011 -0800
tree 462f9100943a8c158c66c16ba0d5c9e4e6e4d7a0
parent f1cc94960a5c636c851b11f3d64d06d7f5379d16

Bug 3362814 Fix SMP race in access to mRequestExit

Also fix an unlikely SMP race in access to mHoldSelf on entry to _threadLoop.

Change-Id: I6cbc0b94739c7dd5e77e8a5ba0da22cdc0b1a4db

include/utils/threads.h

diff --git a/include/utils/threads.h b/include/utils/threads.h
index 1bcfaed..41e5766 100644
--- a/include/utils/threads.h
+++ b/include/utils/threads.h
@@ -527,9 +527,10 @@
     static  int             _threadLoop(void* user);
     const   bool            mCanCallJava;
             thread_id_t     mThread;
-            Mutex           mLock;
+    mutable Mutex           mLock;
             Condition       mThreadExitedCondition;
             status_t        mStatus;
+    // note that all accesses of mExitPending and mRunning need to hold mLock
     volatile bool           mExitPending;
     volatile bool           mRunning;
             sp<Thread>      mHoldSelf;