minor refactoring in praparation of crop fix
Bug: 6498869
Change-Id: I12a6f9a9fdfd2ea1db3fbe5fc8cb443aeaedb328
diff --git a/services/surfaceflinger/Layer.cpp b/services/surfaceflinger/Layer.cpp
index 7eba89b..5988ed2 100644
--- a/services/surfaceflinger/Layer.cpp
+++ b/services/surfaceflinger/Layer.cpp
@@ -232,27 +232,28 @@
// ... then reduce that in the same proportions as the window crop reduces
// the window size.
const State& s(drawingState());
- if (!s.crop.isEmpty()) {
+ if (!s.active.crop.isEmpty()) {
// Transform the window crop to match the buffer coordinate system,
// which means using the inverse of the current transform set on the
// SurfaceTexture.
uint32_t invTransform = mCurrentTransform;
- int winWidth = s.w;
- int winHeight = s.h;
+ int winWidth = s.active.w;
+ int winHeight = s.active.h;
if (invTransform & NATIVE_WINDOW_TRANSFORM_ROT_90) {
invTransform ^= NATIVE_WINDOW_TRANSFORM_FLIP_V |
NATIVE_WINDOW_TRANSFORM_FLIP_H;
- winWidth = s.h;
- winHeight = s.w;
+ winWidth = s.active.h;
+ winHeight = s.active.w;
}
- Rect winCrop = s.crop.transform(invTransform, s.w, s.h);
+ Rect winCrop = s.active.crop.transform(invTransform,
+ s.active.w, s.active.h);
float xScale = float(crop.width()) / float(winWidth);
float yScale = float(crop.height()) / float(winHeight);
- crop.left += int(ceil(float(winCrop.left) * xScale));
- crop.top += int(ceil(float(winCrop.top) * yScale));
- crop.right -= int(ceil(float(winWidth - winCrop.right) * xScale));
- crop.bottom -= int(ceil(float(winHeight - winCrop.bottom) * yScale));
+ crop.left += int(ceilf(float(winCrop.left) * xScale));
+ crop.top += int(ceilf(float(winCrop.top) * yScale));
+ crop.right -= int(ceilf(float(winWidth - winCrop.right) * xScale));
+ crop.bottom -= int(ceilf(float(winHeight - winCrop.bottom) * yScale));
}
return crop;
@@ -427,8 +428,8 @@
const Layer::State& front(drawingState());
const Layer::State& temp(currentState());
- const bool sizeChanged = (front.requested_w != temp.requested_w) ||
- (front.requested_h != temp.requested_h);
+ const bool sizeChanged = (front.requested.w != temp.requested.w) ||
+ (front.requested.h != temp.requested.h);
if (sizeChanged) {
// the size changed, we need to ask our client to request a new buffer
@@ -437,22 +438,22 @@
"resize (layer=%p), requested (%dx%d), drawing (%d,%d), "
"scalingMode=%d",
this,
- int(temp.requested_w), int(temp.requested_h),
- int(front.requested_w), int(front.requested_h),
+ int(temp.requested.w), int(temp.requested.h),
+ int(front.requested.w), int(front.requested.h),
mCurrentScalingMode);
if (!isFixedSize()) {
// this will make sure LayerBase::doTransaction doesn't update
// the drawing state's size
Layer::State& editDraw(mDrawingState);
- editDraw.requested_w = temp.requested_w;
- editDraw.requested_h = temp.requested_h;
+ editDraw.requested.w = temp.requested.w;
+ editDraw.requested.h = temp.requested.h;
}
// record the new size, form this point on, when the client request
// a buffer, it'll get the new size.
- mSurfaceTexture->setDefaultBufferSize(temp.requested_w,
- temp.requested_h);
+ mSurfaceTexture->setDefaultBufferSize(temp.requested.w,
+ temp.requested.h);
}
return LayerBase::doTransaction(flags);
@@ -551,10 +552,10 @@
const Layer::State& front(drawingState());
// FIXME: mPostedDirtyRegion = dirty & bounds
- mPostedDirtyRegion.set(front.w, front.h);
+ mPostedDirtyRegion.set(front.active.w, front.active.h);
- if ((front.w != front.requested_w) ||
- (front.h != front.requested_h))
+ if ((front.active.w != front.requested.w) ||
+ (front.active.h != front.requested.h))
{
// check that we received a buffer of the right size
// (Take the buffer's orientation into account)
@@ -563,15 +564,15 @@
}
if (isFixedSize() ||
- (bufWidth == front.requested_w &&
- bufHeight == front.requested_h))
+ (bufWidth == front.requested.w &&
+ bufHeight == front.requested.h))
{
// Here we pretend the transaction happened by updating the
// current and drawing states. Drawing state is only accessed
// in this thread, no need to have it locked
Layer::State& editDraw(mDrawingState);
- editDraw.w = editDraw.requested_w;
- editDraw.h = editDraw.requested_h;
+ editDraw.active.w = editDraw.requested.w;
+ editDraw.active.h = editDraw.requested.h;
// We also need to update the current state so that we don't
// end-up doing too much work during the next transaction.
@@ -579,8 +580,8 @@
// because State::w and State::h are only accessed from
// this thread
Layer::State& editTemp(currentState());
- editTemp.w = editDraw.w;
- editTemp.h = editDraw.h;
+ editTemp.active.w = editDraw.active.w;
+ editTemp.active.h = editDraw.active.h;
// recompute visible region
recomputeVisibleRegions = true;
@@ -592,7 +593,7 @@
"requested (%dx%d)",
this,
bufWidth, bufHeight, mCurrentTransform,
- front.requested_w, front.requested_h);
+ front.requested.w, front.requested.h);
}
}
}
diff --git a/services/surfaceflinger/LayerBase.cpp b/services/surfaceflinger/LayerBase.cpp
index 81031b1..c52b49c 100644
--- a/services/surfaceflinger/LayerBase.cpp
+++ b/services/surfaceflinger/LayerBase.cpp
@@ -84,16 +84,15 @@
if (flags & ISurfaceComposer::eNonPremultiplied)
mPremultipliedAlpha = false;
- mCurrentState.z = 0;
- mCurrentState.w = w;
- mCurrentState.h = h;
- mCurrentState.requested_w = w;
- mCurrentState.requested_h = h;
- mCurrentState.alpha = 0xFF;
- mCurrentState.flags = layerFlags;
- mCurrentState.sequence = 0;
+ mCurrentState.active.w = w;
+ mCurrentState.active.h = h;
+ mCurrentState.active.crop.makeInvalid();
+ mCurrentState.z = 0;
+ mCurrentState.alpha = 0xFF;
+ mCurrentState.flags = layerFlags;
+ mCurrentState.sequence = 0;
mCurrentState.transform.set(0, 0);
- mCurrentState.crop.makeInvalid();
+ mCurrentState.requested = mCurrentState.active;
// drawing state & current state are identical
mDrawingState = mCurrentState;
@@ -136,10 +135,10 @@
return true;
}
bool LayerBase::setSize(uint32_t w, uint32_t h) {
- if (mCurrentState.requested_w == w && mCurrentState.requested_h == h)
+ if (mCurrentState.requested.w == w && mCurrentState.requested.h == h)
return false;
- mCurrentState.requested_w = w;
- mCurrentState.requested_h = h;
+ mCurrentState.requested.w = w;
+ mCurrentState.requested.h = h;
requestTransaction();
return true;
}
@@ -174,10 +173,10 @@
return true;
}
bool LayerBase::setCrop(const Rect& crop) {
- if (mCurrentState.crop == crop)
+ if (mCurrentState.active.crop == crop)
return false;
mCurrentState.sequence++;
- mCurrentState.crop = crop;
+ mCurrentState.active.crop = crop;
requestTransaction();
return true;
}
@@ -202,15 +201,15 @@
const Layer::State& front(drawingState());
const Layer::State& temp(currentState());
- if ((front.requested_w != temp.requested_w) ||
- (front.requested_h != temp.requested_h)) {
+ if ((front.requested.w != temp.requested.w) ||
+ (front.requested.h != temp.requested.h)) {
// resize the layer, set the physical size to the requested size
Layer::State& editTemp(currentState());
- editTemp.w = temp.requested_w;
- editTemp.h = temp.requested_h;
+ editTemp.active.w = temp.requested.w;
+ editTemp.active.h = temp.requested.h;
}
- if ((front.w != temp.w) || (front.h != temp.h)) {
+ if ((front.active.w != temp.active.w) || (front.active.h != temp.active.h)) {
// invalidate and recompute the visible regions if needed
flags |= Layer::eVisibleRegion;
}
@@ -238,9 +237,9 @@
const bool transformed = tr.transformed();
const DisplayHardware& hw(graphicPlane(0).displayHardware());
const uint32_t hw_h = hw.getHeight();
- const Rect& crop(s.crop);
+ const Rect& crop(s.active.crop);
- Rect win(s.w, s.h);
+ Rect win(s.active.w, s.active.h);
if (!crop.isEmpty()) {
win.intersect(crop, &win);
}
@@ -403,14 +402,14 @@
GLfloat v;
};
- Rect crop(s.w, s.h);
- if (!s.crop.isEmpty()) {
- crop = s.crop;
+ Rect crop(s.active.w, s.active.h);
+ if (!s.active.crop.isEmpty()) {
+ crop = s.active.crop;
}
- GLfloat left = GLfloat(crop.left) / GLfloat(s.w);
- GLfloat top = GLfloat(crop.top) / GLfloat(s.h);
- GLfloat right = GLfloat(crop.right) / GLfloat(s.w);
- GLfloat bottom = GLfloat(crop.bottom) / GLfloat(s.h);
+ GLfloat left = GLfloat(crop.left) / GLfloat(s.active.w);
+ GLfloat top = GLfloat(crop.top) / GLfloat(s.active.h);
+ GLfloat right = GLfloat(crop.right) / GLfloat(s.active.w);
+ GLfloat bottom = GLfloat(crop.bottom) / GLfloat(s.active.h);
TexCoords texCoords[4];
texCoords[0].u = left;
@@ -449,10 +448,12 @@
snprintf(buffer, SIZE,
" "
- "z=%9d, pos=(%g,%g), size=(%4d,%4d), "
+ "z=%9d, pos=(%g,%g), size=(%4d,%4d), crop=(%4d,%4d,%4d,%4d), "
"isOpaque=%1d, needsDithering=%1d, invalidate=%1d, "
"alpha=0x%02x, flags=0x%08x, tr=[%.2f, %.2f][%.2f, %.2f]\n",
- s.z, s.transform.tx(), s.transform.ty(), s.w, s.h,
+ s.z, s.transform.tx(), s.transform.ty(), s.active.w, s.active.h,
+ s.active.crop.left, s.active.crop.top,
+ s.active.crop.right, s.active.crop.bottom,
isOpaque(), needsDithering(), contentDirty,
s.alpha, s.flags,
s.transform[0][0], s.transform[0][1],
diff --git a/services/surfaceflinger/LayerBase.h b/services/surfaceflinger/LayerBase.h
index 31f6dfd..d0b2a74 100644
--- a/services/surfaceflinger/LayerBase.h
+++ b/services/surfaceflinger/LayerBase.h
@@ -65,20 +65,22 @@
Region coveredRegionScreen;
int32_t sequence;
- struct State {
+ struct Geometry {
uint32_t w;
uint32_t h;
- uint32_t requested_w;
- uint32_t requested_h;
+ Rect crop;
+ };
+
+ struct State {
+ Geometry active;
+ Geometry requested;
uint32_t z;
uint8_t alpha;
uint8_t flags;
uint8_t reserved[2];
int32_t sequence; // changes when visible regions can change
- uint32_t tint;
Transform transform;
Region transparentRegion;
- Rect crop;
};
virtual void setName(const String8& name);