commit b4b1730abb7824dc084468c4942f010d94a7e039
author Mathias Agopian <mathias@google.com> Wed Mar 20 18:36:41 2013 -0700
committer Mathias Agopian <mathias@google.com> Thu Mar 21 14:01:53 2013 -0700
tree ad2f3071b7b4acc0133a089e2daf129b0c47174a
parent 7c1a487ba8c0a3b591a77e2ddcb33ef9bdfaff64

only use glReadPixels() when needed when taking screenshots

some drivers don't support this yet, so we use a system
property to enable the glReadPixels "workaround" for them:

  ro.bq.gpu_to_cpu_unsupported=1

Change-Id: I74d6a3a8f0cee8d5a507b72c760cf247e39195e0

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 8546920..2d84c54 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -109,6 +109,9 @@
     // debugging stuff...
     char value[PROPERTY_VALUE_MAX];
 
+    property_get("ro.bq.gpu_to_cpu_unsupported", value, "0");
+    mGpuToCpuSupported = !!atoi(value);
+
     property_get("debug.sf.showupdates", value, "0");
     mDebugRegion = atoi(value);
 
@@ -2546,15 +2549,16 @@
         virtual bool handler() {
             Mutex::Autolock _l(flinger->mStateLock);
             sp<const DisplayDevice> hw(flinger->getDisplayDevice(display));
-            // TODO: if we know the GL->CPU path works, we can call
+            // When we know the GL->CPU path works, we can call
             // captureScreenImplLocked() directly, instead of using the
             // "CpuConsumer" version, which is much less efficient -- it is
             // however needed by some older drivers.
-            if (isCpuConsumer) {
-                result = flinger->captureScreenImplCpuConsumerLocked(hw,
+
+            if (flinger->mGpuToCpuSupported || !isCpuConsumer) {
+                result = flinger->captureScreenImplLocked(hw,
                         producer, reqWidth, reqHeight, minLayerZ, maxLayerZ);
             } else {
-                result = flinger->captureScreenImplLocked(hw,
+                result = flinger->captureScreenImplCpuConsumerLocked(hw,
                         producer, reqWidth, reqHeight, minLayerZ, maxLayerZ);
             }
             return true;

services/surfaceflinger/SurfaceFlinger.h

diff --git a/services/surfaceflinger/SurfaceFlinger.h b/services/surfaceflinger/SurfaceFlinger.h
index 2aacfe7..ef88437 100644
--- a/services/surfaceflinger/SurfaceFlinger.h
+++ b/services/surfaceflinger/SurfaceFlinger.h
@@ -412,6 +412,7 @@
     HWComposer* mHwc;
     GLuint mProtectedTexName;
     nsecs_t mBootTime;
+    bool mGpuToCpuSupported;
     sp<EventThread> mEventThread;
     GLint mMaxViewportDims[2];
     GLint mMaxTextureSize;