commit babba1868773eba5edf8a8e335b8e109a32292e0
author Andy McFadden <fadden@android.com> Wed Sep 12 13:14:51 2012 -0700
committer Andy McFadden <fadden@android.com> Wed Sep 12 13:17:01 2012 -0700
tree a7c825d74d8a66aae454dc1f6854df06140904be
parent 43601a2dc320a271ff8c3765ff61414a07221635

Fix emulator

Emulator has no HWC.

Change-Id: I7810b27034f6772823142e5bf877681db1c8ee49

services/surfaceflinger/DisplayHardware/HWComposer.cpp

diff --git a/services/surfaceflinger/DisplayHardware/HWComposer.cpp b/services/surfaceflinger/DisplayHardware/HWComposer.cpp
index 75b8ad8..992d067 100644
--- a/services/surfaceflinger/DisplayHardware/HWComposer.cpp
+++ b/services/surfaceflinger/DisplayHardware/HWComposer.cpp
@@ -111,9 +111,10 @@
     loadFbHalModule();
     loadHwcModule();
 
-    if (!hwcHasApiVersion(mHwc, HWC_DEVICE_API_VERSION_1_1) && !mFbDev) {
+    // If we have no HWC, or a pre-1.1 HWC, an FB dev is mandatory.
+    if ((!mHwc || !hwcHasApiVersion(mHwc, HWC_DEVICE_API_VERSION_1_1))
+            && !mFbDev) {
         ALOGE("ERROR: failed to open framebuffer, aborting");
-        // FB mandatory on <= 1.0, give up
         abort();
     }
 
@@ -186,7 +187,9 @@
 }
 
 HWComposer::~HWComposer() {
-    mHwc->eventControl(mHwc, 0, EVENT_VSYNC, 0);
+    if (mHwc) {
+        mHwc->eventControl(mHwc, 0, EVENT_VSYNC, 0);
+    }
     if (mVSyncThread != NULL) {
         mVSyncThread->requestExitAndWait();
     }