commit d723bd7669b4fc88dc282d8bf8ba5ecb2849d22f
author Dan Stoza <stoza@google.com> Tue Nov 18 10:24:03 2014 -0800
committer Dan Stoza <stoza@google.com> Fri Dec 05 11:06:44 2014 -0800
tree efc2d81e4ebf1f2499c5c5ec10323c6b3013a5ba
parent a950eb18792da6962fcefa69b12ffc3f9d8cdca8

libgui: Enable -Weverything and -Werror

Enables -Weverything and -Werror, with just a few exceptions for
warnings we can't (or shouldn't need to) work around.

Change-Id: I034abec27bf4020d84af60d7acc1939c59986dd6

include/ui/Rect.h

diff --git a/include/ui/Rect.h b/include/ui/Rect.h
index 31e28d2..895f3a3 100644
--- a/include/ui/Rect.h
+++ b/include/ui/Rect.h
@@ -17,7 +17,10 @@
 #ifndef ANDROID_UI_RECT
 #define ANDROID_UI_RECT
 
+#define LOG_TAG "Rect"
+
 #include <utils/Flattenable.h>
+#include <utils/Log.h>
 #include <utils/TypeHelpers.h>
 #include <ui/Point.h>
 
@@ -43,6 +46,20 @@
         bottom = h;
     }
 
+    inline Rect(uint32_t w, uint32_t h) {
+        if (w > INT32_MAX) {
+            ALOGW("Width %u too large for Rect class, clamping", w);
+            w = INT32_MAX;
+        }
+        if (h > INT32_MAX) {
+            ALOGW("Height %u too large for Rect class, clamping", h);
+            h = INT32_MAX;
+        }
+        left = top = 0;
+        right = w;
+        bottom = h;
+    }
+
     inline Rect(int32_t l, int32_t t, int32_t r, int32_t b) {
         left = l;
         top = t;