commit dba919c5f372872179cd14f8b5beeb4c22fe23c1
author Dave Burke <daveburke@google.com> Fri Oct 05 23:25:57 2012 -0700
committer Android (Google) Code Review <android-gerrit@google.com> Fri Oct 05 23:25:57 2012 -0700
tree 0bfcc0dd2198d99157788ce5d274c3e8680162b4
parent 9504eb915c9628e130f45019bdefda0168089886
parent 0845d0245e09548110cacb0f20e9934753388aab

Merge "ugly, temporary, workaroung for a problem where a binder thread spins forever" into jb-mr1-dev

libs/binder/IPCThreadState.cpp

diff --git a/libs/binder/IPCThreadState.cpp b/libs/binder/IPCThreadState.cpp
index 6e83faa..03c1082 100644
--- a/libs/binder/IPCThreadState.cpp
+++ b/libs/binder/IPCThreadState.cpp
@@ -482,6 +482,18 @@
         if(result == TIMED_OUT && !isMain) {
             break;
         }
+
+        // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK
+        // FIXME: we sometimes get unexplained EINVAL which causes this
+        // thread to spin forever. TEMPORARILY allow it to exit.
+        // We should probably assert on eng builds
+        if(result == -EINVAL && !isMain) {
+            ALOGE("**** THREAD %p (PID %d) ERROR (%d) LEAVING THE THREAD POOL\n",
+                (void*)pthread_self(), getpid(), result);
+            break;
+        }
+        // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK
+
     } while (result != -ECONNREFUSED && result != -EBADF);
 
     LOG_THREADPOOL("**** THREAD %p (PID %d) IS LEAVING THE THREAD POOL err=%p\n",